[jira] [Comment Edited] (SUREFIRE-1881) Java agent printing to native console makes build block when using SurefireForkNodeFactory

["Tibor Digana (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477069#comment-17477069 ] 

Tibor Digana edited comment on SUREFIRE-1881 at 1/17/22, 9:44 AM:
------------------------------------------------------------------

[~kriegaex]

I am glad that you are still testing the snapshot version.

We deploy non-master branches by our hands at the moment.

The work is in progress and it is quite intensive.

The Jenkinsfile was changed by Slawomir, and he did it very well because only master is deployed, see [https://github.com/apache/maven-surefire/commit/5252f16529f90f4413836aef91eac0b88dee9028]

Maybe the problem is that we are deploying the snapshot version due to the issue SUREFIRE-1972.

Snapshot version means that the version is under development and it is on move. It would take few days until we make the snapshot version stable.


was (Author: tibor17):
[~kriegaex]

I am glad that you are still testing the snapshot version.

We have changed the Jenkins deployment where also non-master branches are deployed.

The work is in progress and it is quite intensive.

The Jenkinsfile was changed by Slawomir, and he did it very well because only master is deployed, see [https://github.com/apache/maven-surefire/commit/5252f16529f90f4413836aef91eac0b88dee9028]

Maybe the problem is that we are deploying the snapshot version due to the issue SUREFIRE-1972.

Snapshot version means that the version is under development and it is on move. It would take few days until we make the snapshot version stable.

> Java agent printing to native console makes build block when using SurefireForkNodeFactory
> ------------------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-1881
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1881
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Failsafe Plugin, Maven Surefire Plugin
>    Affects Versions: 3.0.0-M5
>            Reporter: Alexander Kriegisch
>            Assignee: Tibor Digana
>            Priority: Major
>             Fix For: 3.0.0-M6
>
>         Attachments: Bildschirmfoto von 2021-03-29 21-50-25.png, image-2021-02-08-12-07-34-183.png, image-2021-03-26-09-48-11-398.png, image-2021-03-26-09-52-36-881.png, image-2021-03-26-18-00-37-889.png, image-2021-03-31-11-22-50-682.png, image-2021-03-31-11-38-11-119.png, image-2021-03-31-12-31-55-818.png, image-2021-03-31-12-32-41-589.png, maven-failsafe-debug-log.txt, screenshot-1.png, screenshot-2.png
>
>
> This is a follow-up to SUREFIRE-1788 which was closed prematurely even though there still were open issues which were discussed there initially. Basically the situation is as follows:
>  * I use Java agents writing to stdOut and stdErr in my tests.
>  * I was annoyed that Surefire/Failsafe were writing lots of {{[WARNING] Corrupted STDOUT by directly writing to native stream in forked JVM}} lines into {{*-jvmRun1.dumpstream}} files. [~tibordigana] then told me to use {{<forkNode implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>}} in my POM in order to fix the issue.
>  * I tried this in version 3.0.0-M5, but unfortunately, it makes Surefire/Failsafe freeze if a Java agent prints something to stdOut or stdErr. This happens both in M5 and in M6-SNAPSHOT after both SUREFIRE-1788 and SUREFIRE-1809 have been merged in already.
>  * My [sample project|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems] reproduces the issue as soon as you uncomment the option in the POM and run {{mvn clean verify}}.
>  * The second issue is: *Not* using this option leads to garbled log output when a Java agent writes to both stdOut and stdErr before/during tests. See comments in class [{{Agent.DummyTransformer}}|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/src/main/java/de/scrum_master/dummy/Agent.java] for examples for garbled log lines and also comments in [pom.xml|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/pom.xml#L36] for further information.
>  * If the garbled output would also appear with this option activated, cannot be tested at present due to the Surefire/Failsafe freeze. I will re-test that after the freeze has been fixed and before this issue can be closed.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)