You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sergio Pena via Review Board <no...@reviews.apache.org> on 2018/06/11 15:19:10 UTC
Review Request 67527: SENTRY-2262: Sentry client is not compatible
when connecting to Sentry 2.0
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67527/
-----------------------------------------------------------
Review request for sentry and Na Li.
Bugs: SENTRY-2262
https://issues.apache.org/jira/browse/SENTRY-2262
Repository: sentry
Description
-------
This patch fixes an incompatibility between Sentry 2.1 clients and Sentry 2.0 servers.
Diffs
-----
sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java 4e605ae78ffebe54349c4e27c6bc73ee25dd85b6
Diff: https://reviews.apache.org/r/67527/diff/1/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 67527: SENTRY-2262: Sentry client is not
compatible when connecting to Sentry 2.0
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67527/#review204622
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On June 12, 2018, 4:27 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67527/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 4:27 p.m.)
>
>
> Review request for sentry and Na Li.
>
>
> Bugs: SENTRY-2262
> https://issues.apache.org/jira/browse/SENTRY-2262
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This patch fixes an incompatibility between Sentry 2.1 clients and Sentry 2.0 servers.
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java 4e605ae78ffebe54349c4e27c6bc73ee25dd85b6
>
>
> Diff: https://reviews.apache.org/r/67527/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 67527: SENTRY-2262: Sentry client is not
compatible when connecting to Sentry 2.0
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67527/
-----------------------------------------------------------
(Updated June 12, 2018, 4:27 p.m.)
Review request for sentry and Na Li.
Bugs: SENTRY-2262
https://issues.apache.org/jira/browse/SENTRY-2262
Repository: sentry
Description
-------
This patch fixes an incompatibility between Sentry 2.1 clients and Sentry 2.0 servers.
Diffs (updated)
-----
sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java 4e605ae78ffebe54349c4e27c6bc73ee25dd85b6
Diff: https://reviews.apache.org/r/67527/diff/2/
Changes: https://reviews.apache.org/r/67527/diff/1-2/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 67527: SENTRY-2262: Sentry client is not
compatible when connecting to Sentry 2.0
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67527/#review204604
-----------------------------------------------------------
sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java
Lines 237 (patched)
<https://reviews.apache.org/r/67527/#comment287186>
should you add "TODO" in comment indicating we will change the code in the future to use entityName instead?
- Na Li
On June 11, 2018, 3:19 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67527/
> -----------------------------------------------------------
>
> (Updated June 11, 2018, 3:19 p.m.)
>
>
> Review request for sentry and Na Li.
>
>
> Bugs: SENTRY-2262
> https://issues.apache.org/jira/browse/SENTRY-2262
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This patch fixes an incompatibility between Sentry 2.1 clients and Sentry 2.0 servers.
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java 4e605ae78ffebe54349c4e27c6bc73ee25dd85b6
>
>
> Diff: https://reviews.apache.org/r/67527/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 67527: SENTRY-2262: Sentry client is not
compatible when connecting to Sentry 2.0
Posted by Na Li via Review Board <no...@reviews.apache.org>.
> On June 12, 2018, 4:05 p.m., Na Li wrote:
> > sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java
> > Line 236 (original), 236 (patched)
> > <https://reviews.apache.org/r/67527/diff/1/?file=2038114#file2038114line236>
> >
> > should you set the entityName as well?
Talked with Sergio. setting entityName could cause server to throw exception although it is not confirmed.
- Na
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67527/#review204602
-----------------------------------------------------------
On June 11, 2018, 3:19 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67527/
> -----------------------------------------------------------
>
> (Updated June 11, 2018, 3:19 p.m.)
>
>
> Review request for sentry and Na Li.
>
>
> Bugs: SENTRY-2262
> https://issues.apache.org/jira/browse/SENTRY-2262
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This patch fixes an incompatibility between Sentry 2.1 clients and Sentry 2.0 servers.
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java 4e605ae78ffebe54349c4e27c6bc73ee25dd85b6
>
>
> Diff: https://reviews.apache.org/r/67527/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 67527: SENTRY-2262: Sentry client is not
compatible when connecting to Sentry 2.0
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67527/#review204602
-----------------------------------------------------------
sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java
Line 236 (original), 236 (patched)
<https://reviews.apache.org/r/67527/#comment287184>
should you set the entityName as well?
- Na Li
On June 11, 2018, 3:19 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67527/
> -----------------------------------------------------------
>
> (Updated June 11, 2018, 3:19 p.m.)
>
>
> Review request for sentry and Na Li.
>
>
> Bugs: SENTRY-2262
> https://issues.apache.org/jira/browse/SENTRY-2262
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This patch fixes an incompatibility between Sentry 2.1 clients and Sentry 2.0 servers.
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java 4e605ae78ffebe54349c4e27c6bc73ee25dd85b6
>
>
> Diff: https://reviews.apache.org/r/67527/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>