[impala] 01/03: IMPALA-9789: Disable ineffective bloom filters for Kudu scan

[ta...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

tarmstrong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 9429ca7aa2fe127af11073b2fc09bc8e62d2e410
Author: wzhou-code <wz...@cloudera.com>
AuthorDate: Wed Jul 1 22:21:58 2020 -0700

    IMPALA-9789: Disable ineffective bloom filters for Kudu scan
    
    Bump Kudu version to 23f67ae0d. This pulls in the latest version of
    Kudu which includes a performance enhancement in Kudu server for bloom
    filter. Kudu uses same heuristics as HDFS to disable ineffective bloom
    filter. This fixs the performance regression issue for queries like
    TPCH-Q9 so that we can set query option ENABLED_RUNTIME_FILTER_TYPES
    as ALL to enable bloom filter for Kudu by default.
    
    Testing:
     - Ran single_node_perf_run.py with TPCH for Kudu and verified that
       there was no regression issue for each query.
     - Passed all core tests.
    
    Change-Id: Ib55fa359e2fdb2c03c890f2303ffd9173c3c4af1
    Reviewed-on: http://gerrit.cloudera.org:8080/16138
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 bin/impala-config.sh                       | 4 ++--
 common/thrift/ImpalaInternalService.thrift | 2 +-
 common/thrift/ImpalaService.thrift         | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/bin/impala-config.sh b/bin/impala-config.sh
index 0d10496..51faa0d 100755
--- a/bin/impala-config.sh
+++ b/bin/impala-config.sh
@@ -68,7 +68,7 @@ fi
 # moving to a different build of the toolchain, e.g. when a version is bumped or a
 # compile option is changed. The build id can be found in the output of the toolchain
 # build jobs, it is constructed from the build number and toolchain git hash prefix.
-export IMPALA_TOOLCHAIN_BUILD_ID=30-5570b0cd64
+export IMPALA_TOOLCHAIN_BUILD_ID=34-fefac6723e
 # Versions of toolchain dependencies.
 # -----------------------------------
 export IMPALA_AVRO_VERSION=1.7.4-p5
@@ -644,7 +644,7 @@ fi
 # overall build type) and does not apply when using a local Kudu build.
 export USE_KUDU_DEBUG_BUILD=${USE_KUDU_DEBUG_BUILD-false}
 
-export IMPALA_KUDU_VERSION=${IMPALA_KUDU_VERSION-"d652cab17"}
+export IMPALA_KUDU_VERSION=${IMPALA_KUDU_VERSION-"23f67ae0d"}
 export IMPALA_KUDU_JAVA_VERSION=${IMPALA_KUDU_JAVA_VERSION-"1.13.0-SNAPSHOT"}
 export IMPALA_KUDU_HOME=${IMPALA_TOOLCHAIN_PACKAGES_HOME}/kudu-$IMPALA_KUDU_VERSION
 export IMPALA_KUDU_JAVA_HOME=\
diff --git a/common/thrift/ImpalaInternalService.thrift b/common/thrift/ImpalaInternalService.thrift
index 619dc4f..eea7136 100644
--- a/common/thrift/ImpalaInternalService.thrift
+++ b/common/thrift/ImpalaInternalService.thrift
@@ -425,7 +425,7 @@ struct TQueryOptions {
 
   // See comment in ImpalaService.thrift
   104: optional PlanNodes.TEnabledRuntimeFilterTypes enabled_runtime_filter_types =
-      PlanNodes.TEnabledRuntimeFilterTypes.MIN_MAX;
+      PlanNodes.TEnabledRuntimeFilterTypes.ALL;
 
   // See comment in ImpalaService.thrift
   105: optional bool async_codegen = false;
diff --git a/common/thrift/ImpalaService.thrift b/common/thrift/ImpalaService.thrift
index cf526c8..5b63339 100644
--- a/common/thrift/ImpalaService.thrift
+++ b/common/thrift/ImpalaService.thrift
@@ -532,8 +532,8 @@ enum TImpalaQueryOptions {
   // This option only apply to Kudu now, will apply to HDFS once we support
   // min-max filter for HDFS.
   //     BLOOM   - apply bloom filter only,
-  //     MIN_MAX - apply min-max filter only (default).
-  //     ALL     - apply both bloom filter and min-max filter.
+  //     MIN_MAX - apply min-max filter only.
+  //     ALL     - apply both bloom filter and min-max filter (default).
   ENABLED_RUNTIME_FILTER_TYPES = 103
 
   // Enable asynchronous codegen.