[GitHub] [incubator-mxnet] ChaiBapchya edited a comment on issue #17239: Cmake with NCCL flag does not work.

[GitBox <gi...@apache.org>]

ChaiBapchya edited a comment on issue #17239: Cmake with NCCL flag does not work.
URL: https://github.com/apache/incubator-mxnet/issues/17239#issuecomment-573497187
 
 
   I took a look at this auto-detection issue.
   
   To solve this particular case, I added a check for symlink (if UNIX) - https://github.com/ChaiBapchya/incubator-mxnet/blob/nccl_autodetect/cmake/Modules/FindNCCL.cmake
   
   If this is enough, I can submit a PR.
   
   However, I'm not sure if it is complete. Coz I took a look at https://github.com/apache/incubator-mxnet/blob/master/cmake/Modules/FindCUDAToolkit.cmake
   It has a fairly long drawn way of finding the Cuda Toolkit
   1. Language / user provided path
   2. If cuda_root cmake/env not specified, check
   - check symlink 
   - check platform default
   
   Is this what's needed? @leezu @apeforest 
   In that case it makes sense to "factor" out this check as it will be used at 2 places (findCudatoolkit and findNCCL)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services