You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/10 06:47:13 UTC
[GitHub] [pulsar] Tiscs opened a new pull request #8026: [pulsar-functions] Fix message consume ordering issue of function
Tiscs opened a new pull request #8026:
URL: https://github.com/apache/pulsar/pull/8026
Fix #7707
Fix message consume ordering issue of function with EFFECTIVELY_ONCE processing guarantees.
### Motivation
Since v2.5.2, function with EFFECTIVELY_ONCE processing guarantees consume message out of ordering when fail, because process a CompletableFuture result by async.
### Modifications
- Get result from future synchronized when processing guarantees of java instance equals `EFFECTIVELY_ONCE`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #8026: [pulsar-functions] Fix message consume ordering issue of function
Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #8026:
URL: https://github.com/apache/pulsar/pull/8026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #8026: [pulsar-functions] Fix message consume ordering issue of function
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8026:
URL: https://github.com/apache/pulsar/pull/8026#issuecomment-695988428
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #8026: [pulsar-functions] Fix message consume ordering issue of function
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8026:
URL: https://github.com/apache/pulsar/pull/8026#issuecomment-695988428
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8026: [pulsar-functions] Fix message consume ordering issue of function
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8026:
URL: https://github.com/apache/pulsar/pull/8026#issuecomment-848796797
@Tiscs Yes, it should be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8026: [pulsar-functions] Fix message consume ordering issue of function
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8026:
URL: https://github.com/apache/pulsar/pull/8026#issuecomment-728647170
@wolfstudy Please also help review this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Tiscs commented on pull request #8026: [pulsar-functions] Fix message consume ordering issue of function
Posted by GitBox <gi...@apache.org>.
Tiscs commented on pull request #8026:
URL: https://github.com/apache/pulsar/pull/8026#issuecomment-732204345
> @Tiscs Can you add test case for this change and rebase master branch?
Rebased, I'll add some cases later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nlu90 commented on pull request #8026: [pulsar-functions] Fix message consume ordering issue of function
Posted by GitBox <gi...@apache.org>.
nlu90 commented on pull request #8026:
URL: https://github.com/apache/pulsar/pull/8026#issuecomment-844568873
This PR might be a duplicate for this one: #10618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8026: [pulsar-functions] Fix message consume ordering issue of function
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8026:
URL: https://github.com/apache/pulsar/pull/8026#issuecomment-845726582
Sorry @Tiscs, we are merged #10618, and due to too long time this PR opened, we missed this one, thanks for the contribution. I will close this PR first and welcome to contribute more fixes and features in the Pulsar community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8026: [pulsar-functions] Fix message consume ordering issue of function
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8026:
URL: https://github.com/apache/pulsar/pull/8026#issuecomment-843808949
@Tiscs Could please rebase the master branch? There are related changes merged into the master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Tiscs commented on pull request #8026: [pulsar-functions] Fix message consume ordering issue of function
Posted by GitBox <gi...@apache.org>.
Tiscs commented on pull request #8026:
URL: https://github.com/apache/pulsar/pull/8026#issuecomment-845843323
> Sorry @Tiscs, we are merged #10618, and due to too long time this PR opened, we missed this one, thanks for the contribution. I will close this PR first and welcome to contribute more fixes and features in the Pulsar community.
Should the issue #7707 be closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8026: [pulsar-functions] Fix message consume ordering issue of function
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8026:
URL: https://github.com/apache/pulsar/pull/8026#issuecomment-728647067
move to 2.8.0 first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #8026: [pulsar-functions] Fix message consume ordering issue of function
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #8026:
URL: https://github.com/apache/pulsar/pull/8026#issuecomment-731183999
@Tiscs Can you add test case for this change and rebase master branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org