You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "buraksenn (via GitHub)" <gi...@apache.org> on 2026/07/04 21:48:57 UTC
[PR] fix: gate debug-only assertions in physical planner test test_optimization_invariant_checker [datafusion]
buraksenn opened a new pull request, #23323:
URL: https://github.com/apache/datafusion/pull/23323
## Which issue does this PR close?
- Closes #20786
## Rationale for this change
`test_optimization_invariant_checker` panics under `release-nonlto` profile which has debug_assertions=false. Thus, we need to gate
## What changes are included in this PR?
Make sure debug_assertion required places are behind that gate
## Are these changes tested?
Yes and this is test only change.
```
cargo test physical_planner --profile release-nonlto
```
now passes since we skip these checks as they are not supported in that profile
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: gate debug-only assertions in physical planner test test_optimization_invariant_checker [datafusion]
Posted by "xudong963 (via GitHub)" <gi...@apache.org>.
xudong963 merged PR #23323:
URL: https://github.com/apache/datafusion/pull/23323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: gate debug-only assertions in physical planner test test_optimization_invariant_checker [datafusion]
Posted by "buraksenn (via GitHub)" <gi...@apache.org>.
buraksenn commented on PR #23323:
URL: https://github.com/apache/datafusion/pull/23323#issuecomment-4885931975
> How about using ` cfg!(debug_assertions)` which adds an explicit `assert!(result.is_ok())` for release mode and removes the need to gate `InvariantFailsExtensionNode`, giving strictly better coverage with less #[cfg] surface.
Thanks, I did not think of this. I've applied it just now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org