You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/13 10:58:01 UTC
[GitHub] [apisix] tzssangglass opened a new pull request #2409: feature: support multiple ports like stream listen in http and https …
tzssangglass opened a new pull request #2409:
URL: https://github.com/apache/apisix/pull/2409
…listen port. (#1195)
fix #1195
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
The Apache APISIX listens to a single port by default in http and https, this PR support multiple ports listen.
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #2409: feature: support multiple ports like stream listen in http and https …
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #2409:
URL: https://github.com/apache/apisix/pull/2409#issuecomment-709657316
need test case for change.
here is an example:
https://github.com/apache/apisix/blob/master/.travis/apisix_cli_test.sh#L156-L170
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #2409: feature: support multiple ports like stream listen in http and https …
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2409:
URL: https://github.com/apache/apisix/pull/2409#discussion_r505616200
##########
File path: FAQ.md
##########
@@ -270,3 +270,21 @@ If your APISIX node does not open the Admin API, then you can manually load the
```shell
apisix reload
```
+
+## How to support multiple ports in http and https listen port？
+
+The Apache APISIX listens to a single port by default. If you need to support http or https to listen to multiple ports, modify the steps:
Review comment:
The English sentence here is not very good. You need to write another one.
You can use deepl.com ^_^.
##########
File path: FAQ_CN.md
##########
@@ -220,3 +220,23 @@ curl http://127.0.0.1:9080/apisix/admin/plugins/reload -H 'X-API-KEY: edd1c9f034
```shell
apisix reload
```
+
+## 如何支持http和https多端口监听
+apisix默认监听单端口，如果需要支持http或https监听多端口，修改步骤：
+
+1、修改conf/config.yaml中的http端口监听的配置参数`node_listen`，或https端口监听的参数`ssl.listen_port`，格式如下
+```
Review comment:
ditto
##########
File path: FAQ_CN.md
##########
@@ -220,3 +220,23 @@ curl http://127.0.0.1:9080/apisix/admin/plugins/reload -H 'X-API-KEY: edd1c9f034
```shell
apisix reload
```
+
+## 如何支持http和https多端口监听
+apisix默认监听单端口，如果需要支持http或https监听多端口，修改步骤：
+
+1、修改conf/config.yaml中的http端口监听的配置参数`node_listen`，或https端口监听的参数`ssl.listen_port`，格式如下
+```
Review comment:
修改conf/config.yaml中的http端口监
->
修改`conf/config.yaml`中的 HTTP 端口监
##########
File path: FAQ_CN.md
##########
@@ -220,3 +220,23 @@ curl http://127.0.0.1:9080/apisix/admin/plugins/reload -H 'X-API-KEY: edd1c9f034
```shell
apisix reload
```
+
+## 如何支持http和https多端口监听
+apisix默认监听单端口，如果需要支持http或https监听多端口，修改步骤：
+
+1、修改conf/config.yaml中的http端口监听的配置参数`node_listen`，或https端口监听的参数`ssl.listen_port`，格式如下
+```
+apisix:
+ node_listen:
+ - 9080
+ - 9081
+ - 9082
+ ssl:
+ listen_port:
+ - 9443
+ - 9444
+ - 9445
+```
+
+2、重启APISIX
Review comment:
need a space between Chinese and English
##########
File path: FAQ_CN.md
##########
@@ -220,3 +220,23 @@ curl http://127.0.0.1:9080/apisix/admin/plugins/reload -H 'X-API-KEY: edd1c9f034
```shell
apisix reload
```
+
+## 如何支持http和https多端口监听
+apisix默认监听单端口，如果需要支持http或https监听多端口，修改步骤：
Review comment:
add a blank line before this line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #2409: feature: support multiple ports like stream listen in http and https …
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #2409:
URL: https://github.com/apache/apisix/pull/2409#issuecomment-709716973
The last commit was on my company's virtual machine. Maybe it caused the security check to fail. In the evening I will submit from my own computer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2409: feature: support multiple ports like stream listen in http and https …
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2409:
URL: https://github.com/apache/apisix/pull/2409#issuecomment-709662087
please take a look at the output of CI: https://github.com/apache/apisix/pull/2409/checks?check_run_id=1260519517#step:6:125
```
Scan detected 6 error(s) in 2 file(s):
Reading configuration file [.travis/ASF-Release.cfg]...
Scanning files starting at [./]...
Scan detected 6 error(s) in 2 file(s):
[./FAQ.md]:
279: line has trailing whitespace.
287: line has trailing whitespace.
289: line has trailing whitespace.
298: line has trailing whitespace.
[./FAQ_CN.md]:
237: line has trailing whitespace.
239: line has trailing whitespace.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #2409: feature: support multiple ports like stream listen in http and https …
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #2409:
URL: https://github.com/apache/apisix/pull/2409#issuecomment-708867867
someone else can approved?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #2409: feature: support multiple ports like stream listen in http and https …
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #2409:
URL: https://github.com/apache/apisix/pull/2409#discussion_r505641469
##########
File path: FAQ.md
##########
@@ -270,3 +270,21 @@ If your APISIX node does not open the Admin API, then you can manually load the
```shell
apisix reload
```
+
+## How to support multiple ports in http and https listen port？
+
+The Apache APISIX listens to a single port by default. If you need to support http or https to listen to multiple ports, modify the steps:
Review comment:
^_^ haha, ok, I use this site for translations, thanks for the guidance!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #2409: feature: support multiple ports like stream listen in http and https …
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #2409:
URL: https://github.com/apache/apisix/pull/2409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis removed a comment on pull request #2409: feature: support multiple ports like stream listen in http and https …
Posted by GitBox <gi...@apache.org>.
membphis removed a comment on pull request #2409:
URL: https://github.com/apache/apisix/pull/2409#issuecomment-707708556
@tzssangglass you need to update the `config-default.yaml` file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #2409: feature: support multiple ports like stream listen in http and https …
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2409:
URL: https://github.com/apache/apisix/pull/2409#discussion_r505939278
##########
File path: FAQ.md
##########
@@ -271,20 +271,29 @@ If your APISIX node does not open the Admin API, then you can manually load the
apisix reload
```
-## How to support multiple ports in http and https listen port？
+## How to make APISIX listen on multiple ports when handling HTTP or HTTPS requests?
-The Apache APISIX listens to a single port by default. If you need to support http or https to listen to multiple ports, modify the steps:
-1. Modify the parameter of http port listen `node_listen`, or https port listen `ssl.listen_port` in conf/config.yaml, style like
- ```
+By default, APISIX only listens on port 9080 when handling HTTP requests. If you want APISIX to listen on multiple ports, you need to modify the relevant parameters in the configuration file as follows:
+
+1. Modify the parameter of HTTP port listen `node_listen` in `conf/config.yaml`, style like
+
+ ```
apisix:
node_listen:
- 9080
- 9081
- 9082
+ ```
+
+ Handling https requests is similar, Modify the parameter of HTTPS port listen `ssl.listen_port` in `conf/config.yaml`, style like
Review comment:
`http` -> `HTTP`
`https` -> `HTTPS`
##########
File path: FAQ.md
##########
@@ -271,20 +271,29 @@ If your APISIX node does not open the Admin API, then you can manually load the
apisix reload
```
-## How to support multiple ports in http and https listen port？
+## How to make APISIX listen on multiple ports when handling HTTP or HTTPS requests?
-The Apache APISIX listens to a single port by default. If you need to support http or https to listen to multiple ports, modify the steps:
-1. Modify the parameter of http port listen `node_listen`, or https port listen `ssl.listen_port` in conf/config.yaml, style like
- ```
+By default, APISIX only listens on port 9080 when handling HTTP requests. If you want APISIX to listen on multiple ports, you need to modify the relevant parameters in the configuration file as follows:
+
+1. Modify the parameter of HTTP port listen `node_listen` in `conf/config.yaml`, style like
+
+ ```
apisix:
node_listen:
- 9080
- 9081
- 9082
+ ```
+
+ Handling https requests is similar, Modify the parameter of HTTPS port listen `ssl.listen_port` in `conf/config.yaml`, style like
Review comment:
`style like` -> `for example:`
##########
File path: FAQ.md
##########
@@ -271,20 +271,29 @@ If your APISIX node does not open the Admin API, then you can manually load the
apisix reload
```
-## How to support multiple ports in http and https listen port？
+## How to make APISIX listen on multiple ports when handling HTTP or HTTPS requests?
-The Apache APISIX listens to a single port by default. If you need to support http or https to listen to multiple ports, modify the steps:
-1. Modify the parameter of http port listen `node_listen`, or https port listen `ssl.listen_port` in conf/config.yaml, style like
- ```
+By default, APISIX only listens on port 9080 when handling HTTP requests. If you want APISIX to listen on multiple ports, you need to modify the relevant parameters in the configuration file as follows:
+
+1. Modify the parameter of HTTP port listen `node_listen` in `conf/config.yaml`, style like
+
+ ```
apisix:
node_listen:
- 9080
- 9081
- 9082
+ ```
+
+ Handling https requests is similar, Modify the parameter of HTTPS port listen `ssl.listen_port` in `conf/config.yaml`, style like
Review comment:
`Modify` -> `modify`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2409: feature: support multiple ports like stream listen in http and https …
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2409:
URL: https://github.com/apache/apisix/pull/2409#issuecomment-707709150
CI output:
```
+ ./bin/apisix init
lua: ./bin/apisix:887: attempt to call field 'new' (a nil value)
stack traceback:
./bin/apisix:887: in function '?'
./bin/apisix:1154: in main chunk
[C]: ?
Error: Process completed with exit code 1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #2409: feature: support multiple ports like stream listen in http and https …
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #2409:
URL: https://github.com/apache/apisix/pull/2409#issuecomment-709714934
> need test case for change.
>
> here is an example:
>
> https://github.com/apache/apisix/blob/master/.travis/apisix_cli_test.sh#L156-L170
ok, thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2409: feature: support multiple ports like stream listen in http and https …
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2409:
URL: https://github.com/apache/apisix/pull/2409#issuecomment-707708556
@tzssangglass you need to update the `config-default.yaml` file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #2409: feature: support multiple ports like stream listen in http and https …
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #2409:
URL: https://github.com/apache/apisix/pull/2409#issuecomment-708194775
someone else can approved?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org