[GitHub] [skywalking] mrproliu commented on a change in pull request #4490: Fix GraphQL profile queried error when cannot matches any snapshot

[GitBox <gi...@apache.org>]

mrproliu commented on a change in pull request #4490: Fix GraphQL profile queried error when cannot matches any snapshot
URL: https://github.com/apache/skywalking/pull/4490#discussion_r390807805
 
 

 ##########
 File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileAnalyzer.java
 ##########
 @@ -88,7 +88,7 @@ public ProfileAnalyzation analyze(String segmentId, List<ProfileAnalyzeTimeRange
         }).flatMap(Collection::stream).map(ProfileStack::deserialize).distinct().collect(Collectors.toList());
 
         // analyze
-        analyzation.setTrees(analyze(stacks));
+        analyzation.getTrees().addAll(analyze(stacks));
 
 Review comment:
   My fault. I will add an `if` judge before `addAll`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services