You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by dannylane <gi...@git.apache.org> on 2017/12/30 02:02:57 UTC
[GitHub] nifi-registry pull request #74: NIFIREG-89 Add landing page for root URL '/'
GitHub user dannylane opened a pull request:
https://github.com/apache/nifi-registry/pull/74
NIFIREG-89 Add landing page for root URL '/'
Following on from a suggestion in the dev mailing list I created [NIFIREG-89](https://issues.apache.org/jira/browse/NIFIREG-89) to add a landing page informing the user they may have mistyped, similar to the page that currently exists in NiFi.
I followed a similar approach as was used in NiFi.
This is the page that has been added:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dannylane/nifi-registry NIFIREG-89
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-registry/pull/74.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #74
----
commit 09d6ec4ba0e7f36e07f07deac76d4304339d32b6
Author: Danny Lane <da...@...>
Date: 2017-12-30T01:43:09Z
NIFIREG-89 Add landing page for default url
----
---
[GitHub] nifi-registry issue #74: NIFIREG-89 Add landing page for root URL '/'
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/74
@dannylane thanks for the contribution! From a quick glance this looks good, will do a more detailed review when I get a chance.
One thing that will need to be done is providing a LICENSE & NOTICE inside the nifi-registry-web-errors WAR at src/main/resources/META-INF, similar to this:
https://github.com/apache/nifi-registry/tree/master/nifi-registry-web-ui/src/main/resources/META-INF
If the web-errors WAR does not bundle any third party libraries (JARs or JS/CSS) then the LICENSE will most likely be the regular ASLv2 license, and the NOTICE would just be:
```
nifi-registry-web-errors
Copyright 2014-2017 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
```
If the WAR does bundle other libraries then they may need to be mentioned in the license or notice.
---
[GitHub] nifi-registry issue #74: NIFIREG-89 Add landing page for root URL '/'
Posted by dannylane <gi...@git.apache.org>.
Github user dannylane commented on the issue:
https://github.com/apache/nifi-registry/pull/74
Thanks @bbende, I've added the LICENSE & NOTICE.
Let me know if there's anything else that needs to be changed.
---
[GitHub] nifi-registry issue #74: NIFIREG-89 Add landing page for root URL '/'
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/74
@alopresto thanks for mentioning about the discussion of the NiFi landing page, I wasn't aware of that.
Even if we changed to a silent redirect, I _think_ we still want most of what is in this PR. What I mean is that this PR sets up the new WAR that handles the "/" context and currently displays the index.html from nifi-registry-web-errors WAR, which happens to be the landing page.
If we wanted to redirect instead, I think we'd just be changing how the index.html worked at that point, maybe to something like index.jsp that called redirect? But in either case we need something to handle the root context of "/".
---
[GitHub] nifi-registry pull request #74: NIFIREG-89 Add landing page for root URL '/'
Posted by dannylane <gi...@git.apache.org>.
Github user dannylane closed the pull request at:
https://github.com/apache/nifi-registry/pull/74
---
[GitHub] nifi-registry issue #74: NIFIREG-89 Add landing page for root URL '/'
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi-registry/pull/74
There has actually been discussion on the NiFi side about removing this page. It is a legacy artifact that introduces a number of problems and doesn't serve a purpose that a silent redirect would not accomplish. Can we please hold off on merging this until the decision is made on the NiFi side about removing the page? Feel free to contribute to that discussion as well (I believe at this time, it has been conducted offline, so I will send an email to the dev mailing list to introduce the topic).
---