[jira] [Resolved] (HIVE-5044) StringUtils

["David Mollitor (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Mollitor resolved HIVE-5044.
----------------------------------
    Resolution: Won't Fix

Please re-open and submit a new patch if you would like.

> StringUtils
> -----------
>
>                 Key: HIVE-5044
>                 URL: https://issues.apache.org/jira/browse/HIVE-5044
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Benjamin Jakobus
>            Assignee: Benjamin Jakobus
>            Priority: Major
>
> When you see code like this:
> first = true;
> for (int k = 0; k < columnSize; k++) {
> String newColName = i + "VALUE" + k; // any name, it does not matter.
> + newColName = i + "VALUE" + k; // any name, it does not matter.
> if (!first)
> Unknown macro: { - valueColNames = valueColNames + ","; - valueColTypes = valueColTypes + ","; + valueColNames.append(","); + valueColTypes.append(","); }
> valueColNames = valueColNames + newColName;
> valueColTypes = valueColTypes + valueCols.get(k).getTypeString();
> + valueColNames.append(newColName);
> + valueColTypes.append(valueCols.get(k).getTypeString());
> first = false;
> Can you replace it with StringUtil.join()
> I have seen this about 4 places in hive.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)