[GitHub] [lucene-solr] kwatters commented on pull request #2185: LUCENE-9659 inequality support in payload check query

[GitBox <gi...@apache.org>]

kwatters commented on pull request #2185:
URL: https://github.com/apache/lucene-solr/pull/2185#issuecomment-770416890


   I simplified the equals operator, and as a result pulled out the MatchOperation into an enum.  I think this is probably cleaner.  Additional test cases were added to the testEquality tests in the TestPayloadCheckQuery to handle a few extra cases there weren't exercised before.  
   
   As for the lambda's , where were you suggesting to use a lambda?  Perhaps, that's a refactor for another time,  I think the performance of the current impl is pretty tight as it is.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org