[jira] [Commented] (YETUS-721) personalities shouldn't directly set repository information

["Allen Wittenauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733724#comment-16733724 ] 

Allen Wittenauer commented on YETUS-721:
----------------------------------------

-00:
* I went with _DEFAULT.

> personalities shouldn't directly set repository information
> -----------------------------------------------------------
>
>                 Key: YETUS-721
>                 URL: https://issues.apache.org/jira/browse/YETUS-721
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>    Affects Versions: 0.8.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Critical
>             Fix For: 0.9.0
>
>         Attachments: YETUS-721.00.patch
>
>
> One of the key learnings from YETUS-681 is that it's pretty harmful for forks if the personality specifically sets the github repo:
> 1) User forks apache/yetus
> 2) User configures Travis CI to run their local yetus repo
> 3) User makes a pull request against their local yetus repo
> 4) test-patch reads the github info from Travis CI to know the repo location
> 5) User sets --project=yetus, which then changes the github information to apache/yetus
> 6) Pull request test fails because that PR doesn't exist in apache/yetus



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)