You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/20 06:39:35 UTC
[GitHub] [apisix-helm-chart] PGDream opened a new pull request #254: Ingress classname
PGDream opened a new pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254
ingress on high version，can ingressClassName attribe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on a change in pull request #254: Ingress classname
Posted by GitBox <gi...@apache.org>.
PGDream commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r830716265
##########
File path: charts/apisix-dashboard/templates/ingress.yaml
##########
@@ -24,6 +24,9 @@ apiVersion: extensions/v1beta1
{{- end }}
kind: Ingress
metadata:
+ {{- if .Values.ingress.classNmae }}
+ ingressClassName: {{- .Values.ingress.classNmae -}}
Review comment:
hi,readme.md already update;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream closed pull request #254: Ingress classname
Posted by GitBox <gi...@apache.org>.
PGDream closed pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on a change in pull request #254: Ingress classname
Posted by GitBox <gi...@apache.org>.
PGDream commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r830577422
##########
File path: charts/apisix-dashboard/templates/ingress.yaml
##########
@@ -24,6 +24,9 @@ apiVersion: extensions/v1beta1
{{- end }}
kind: Ingress
metadata:
+ {{- if .Values.ingress.classNmae }}
+ ingressClassName: {{- .Values.ingress.classNmae -}}
Review comment:
values.yaml file describe "ingressClassName" kubernetes version ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on a change in pull request #254: Ingress classname
Posted by GitBox <gi...@apache.org>.
PGDream commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r831746074
##########
File path: charts/apisix-dashboard/values.yaml
##########
@@ -86,9 +86,17 @@ service:
ingress:
enabled: false
+ # kubernetes ingress attribe ingressClassName,default to "apisix"
+ # Kubernetes 1.18+ support ingressClassName attribe
+ className: "apisix"
Review comment:
why? is become kubernetes version not upgrade!?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on a change in pull request #254: Ingress classname
Posted by GitBox <gi...@apache.org>.
PGDream commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r830606759
##########
File path: charts/apisix-dashboard/templates/ingress.yaml
##########
@@ -24,6 +24,9 @@ apiVersion: extensions/v1beta1
{{- end }}
kind: Ingress
metadata:
+ {{- if .Values.ingress.classNmae }}
+ ingressClassName: {{- .Values.ingress.classNmae -}}
Review comment:
thx, already edited;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #254: Ingress classname
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r830702118
##########
File path: charts/apisix-dashboard/templates/ingress.yaml
##########
@@ -24,6 +24,9 @@ apiVersion: extensions/v1beta1
{{- end }}
kind: Ingress
metadata:
+ {{- if .Values.ingress.classNmae }}
+ ingressClassName: {{- .Values.ingress.classNmae -}}
Review comment:
Yes, but I think readme should also be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #254: Ingress classname
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r831746882
##########
File path: charts/apisix-dashboard/values.yaml
##########
@@ -86,9 +86,17 @@ service:
ingress:
enabled: false
+ # kubernetes ingress attribe ingressClassName,default to "apisix"
+ # Kubernetes 1.18+ support ingressClassName attribe
+ className: "apisix"
Review comment:
Yes, we need to maintain compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #254: Ingress classname
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r830567364
##########
File path: charts/apisix-dashboard/templates/ingress.yaml
##########
@@ -24,6 +24,9 @@ apiVersion: extensions/v1beta1
{{- end }}
kind: Ingress
metadata:
+ {{- if .Values.ingress.classNmae }}
+ ingressClassName: {{- .Values.ingress.classNmae -}}
Review comment:
There is a minimum version constraint for Kubernetes, Please update the document to classify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #254: Ingress classname
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream closed pull request #254: Ingress classname
Posted by GitBox <gi...@apache.org>.
PGDream closed pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #254: Ingress classname
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r830593849
##########
File path: charts/apisix-dashboard/values.yaml
##########
@@ -86,9 +86,16 @@ service:
ingress:
enabled: false
+ # kubernetes ingress attribe ingressClassName,default to "apisix"
+ classNamw: "apisix"
Review comment:
```suggestion
className: "apisix"
```
##########
File path: charts/apisix-dashboard/templates/ingress.yaml
##########
@@ -24,6 +24,9 @@ apiVersion: extensions/v1beta1
{{- end }}
kind: Ingress
metadata:
+ {{- if .Values.ingress.classNmae }}
+ ingressClassName: {{- .Values.ingress.classNmae -}}
Review comment:
```suggestion
ingressClassName: {{- .Values.ingress.className -}}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] PGDream commented on a change in pull request #254: Ingress classname
Posted by GitBox <gi...@apache.org>.
PGDream commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r831785797
##########
File path: charts/apisix-dashboard/values.yaml
##########
@@ -86,9 +86,17 @@ service:
ingress:
enabled: false
+ # kubernetes ingress attribe ingressClassName,default to "apisix"
+ # Kubernetes 1.18+ support ingressClassName attribe
+ className: "apisix"
Review comment:
ok, please reaudit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #254: Ingress classname
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r831710220
##########
File path: charts/apisix-dashboard/values.yaml
##########
@@ -86,9 +86,17 @@ service:
ingress:
enabled: false
+ # kubernetes ingress attribe ingressClassName,default to "apisix"
+ # Kubernetes 1.18+ support ingressClassName attribe
+ className: "apisix"
Review comment:
We should comment it by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org