You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Jacek Laskowski <ja...@laskowski.net.pl> on 2008/08/20 23:46:29 UTC
Re: svn commit: r687475 - /geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.jee.v21.jaxbmodel/src/main/java/org/apache/geronimo/jee/deployment/Artifact.java
On Wed, Aug 20, 2008 at 11:34 PM, <mc...@apache.org> wrote:
> Author: mcconne
> Date: Wed Aug 20 14:34:53 2008
> New Revision: 687475
>
> URL: http://svn.apache.org/viewvc?rev=687475&view=rev
> Log:
> GERONIMODEVTOOLS-489 Clean-up insertion of empty xml tags. Thanks to BJ Reed for this patch !!
>
> Modified:
> geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.jee.v21.jaxbmodel/src/main/java/org/apache/geronimo/jee/deployment/Artifact.java
>
> Modified: geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.jee.v21.jaxbmodel/src/main/java/org/apache/geronimo/jee/deployment/Artifact.java
> URL: http://svn.apache.org/viewvc/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.jee.v21.jaxbmodel/src/main/java/org/apache/geronimo/jee/deployment/Artifact.java?rev=687475&r1=687474&r2=687475&view=diff
> ==============================================================================
> --- geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.jee.v21.jaxbmodel/src/main/java/org/apache/geronimo/jee/deployment/Artifact.java (original)
> +++ geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.jee.v21.jaxbmodel/src/main/java/org/apache/geronimo/jee/deployment/Artifact.java Wed Aug 20 14:34:53 2008
> @@ -168,7 +168,10 @@
> *
> */
> public void setVersion(String value) {
> - this.version = value;
> + if (value == null || value.length() == 0)
> + this.version = null;
> + else
> + this.version = value;
> }
Shouldn't curly braces be used in the if stmt? (cf.
http://geronimo.apache.org/coding-standards.html)
Jacek
--
Jacek Laskowski
Notatnik Projektanta Java EE - http://www.JacekLaskowski.pl