[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #213: refactoring helm chart

[GitBox <gi...@apache.org>]

gxthrj commented on a change in pull request #213:
URL: https://github.com/apache/apisix-ingress-controller/pull/213#discussion_r567805206



##########
File path: charts/apisix-ingress-controller/values.yaml
##########
@@ -0,0 +1,72 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Default values for apisix-ingress-controller.
+# This is a YAML-formatted file.
+# Declare variables to be passed into your templates.
+#
+nameOverride: ""
+
+fullnameOverride: ""
+
+rbac:
+  # Specifies whether RBAC resources should be created
+  create: true
+
+serviceAccount:
+  # Specifies whether a ServiceAccount should be created
+  create: true
+  # The name of the ServiceAccount to use.
+  # If not set and create is true, a name is generated using the fullname template
+  name: ~
+
+replicaCount: 1
+
+image:
+  repository: apache/apisix-ingress-controller
+  pullPolicy: IfNotPresent
+  tag: "0.1.0"

Review comment:
       Please set to 0.2.0 by default :)

##########
File path: charts/apisix-ingress-controller/Chart.yaml
##########
@@ -15,13 +15,14 @@
 # limitations under the License.
 #
 apiVersion: v2
-name: ingress-apisix
+name: apisix-ingress-controller
 description: Apache APISIX Ingress Controller for Kubernetes
 icon: https://apache.org/logos/res/apisix/apisix.png
 keywords:
   - ingress
   - apisix
   - nginx
+  - crd
 type: application
 version: 0.1.0
 appVersion: 0.1.0

Review comment:
       0.2.0 has been released before, and I pushed the 0.2.0 image to [dockerhub](https://hub.docker.com/r/apache/apisix-ingress-controller/tags?page=1&ordering=last_updated&name=0.2.0) just now 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org