You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pritisarap12 <gi...@git.apache.org> on 2015/07/23 11:45:52 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8664: Verify if queryAsyncJobR...
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/619
CLOUDSTACK-8664: Verify if queryAsyncJobResult api return jobinstanceid
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pritisarap12/cloudstack CLOUDSTACK-8664-Verify-if-queryAsyncJobResult-api-return-jobinstanceid
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/619.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #619
----
commit 292734324c81f8fd1fa92606aa42e73dc583c15c
Author: Priti Sarap <pr...@clogeny.com>
Date: 2015-07-23T09:38:35Z
CLOUDSTACK-8664: Verify if queryAsyncJobResult api return jobinstanceid
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8664: Verify if queryAsyncJobR...
Posted by Sanjeev N <sa...@apache.org>.
LGTM!!
On Mon, Jul 27, 2015 at 12:11 PM, pritisarap12 <gi...@git.apache.org> wrote:
> Github user pritisarap12 commented on a diff in the pull request:
>
> https://github.com/apache/cloudstack/pull/619#discussion_r35508814
>
> --- Diff: test/integration/testpaths/testpath_queryAsyncJobResult.py
> ---
> @@ -0,0 +1,133 @@
> +# Licensed to the Apache Software Foundation (ASF) under one
> +# or more contributor license agreements. See the NOTICE file
> +# distributed with this work for additional information
> +# regarding copyright ownership. The ASF licenses this file
> +# to you under the Apache License, Version 2.0 (the
> +# "License"); you may not use this file except in compliance
> +# with the License. You may obtain a copy of the License at
> +#
> +# http://www.apache.org/licenses/LICENSE-2.0
> +#
> +# Unless required by applicable law or agreed to in writing,
> +# software distributed under the License is distributed on an
> +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> +# KIND, either express or implied. See the License for the
> +# specific language governing permissions and limitations
> +# under the License.
> +""" Test case to check if queryAsyncJobResult returns jobinstanceid
> +"""
> +from nose.plugins.attrib import attr
> +from marvin.cloudstackTestCase import cloudstackTestCase
> +from marvin.lib.utils import (cleanup_resources)
> +from marvin.lib.base import (Account,
> + ServiceOffering,
> + VirtualMachine,
> + )
> +from marvin.lib.common import (get_domain,
> + get_zone,
> + get_template,
> + )
> +
> +from marvin.cloudstackAPI import queryAsyncJobResult
> +
> +class TestJobinstanceid(cloudstackTestCase):
> +
> + @classmethod
> + def setUpClass(cls):
> + testClient = super(TestJobinstanceid, cls).getClsTestClient()
> + cls.apiclient = testClient.getApiClient()
> + cls.testdata = testClient.getParsedTestDataConfig()
> +
> + cls.hypervisor = cls.testClient.getHypervisorInfo()
> + # Get Zone, Domain and templates
> + cls.domain = get_domain(cls.apiclient)
> + cls.zone = get_zone(cls.apiclient,
> testClient.getZoneForTests())
> +
> + cls.template = get_template(
> + cls.apiclient,
> + cls.zone.id,
> + cls.testdata["ostype"])
> +
> + cls._cleanup = []
> +
> + try:
> +
> + # Create an account
> + cls.account = Account.create(
> + cls.apiclient,
> + cls.testdata["account"],
> + domainid=cls.domain.id
> + )
> + # Create user api client of the account
> + cls.userapiclient = testClient.getUserApiClient(
> + UserName=cls.account.name,
> + DomainName=cls.account.domain
> + )
> +
> + # Create Service offering
> + cls.service_offering = ServiceOffering.create(
> + cls.apiclient,
> + cls.testdata["service_offering"],
> + )
> +
> + cls._cleanup = [
> + cls.account,
> + cls.service_offering,
> + ]
> + except Exception as e:
> + cls.tearDownClass()
> + raise e
> + return
> +
> +
> + @classmethod
> + def tearDownClass(cls):
> + try:
> + cleanup_resources(cls.apiclient, cls._cleanup)
> + except Exception as e:
> + raise Exception("Warning: Exception during cleanup : %s"
> % e)
> +
> + def setUp(self):
> + self.apiclient = self.testClient.getApiClient()
> + self.dbclient = self.testClient.getDbConnection()
> + self.cleanup = []
> +
> + def tearDown(self):
> + try:
> + cleanup_resources(self.apiclient, self.cleanup)
> + except Exception as e:
> + raise Exception("Warning: Exception during cleanup : %s"
> % e)
> + return
> +
> + @attr(tags=["advanced", "basic"], required_hardware="false")
> + def test_queryAsyncJobResult_jobinstanceid(self):
> + """ Test queryAsyncJobResult api return jobinstanceid
> +
> + # 1. Deploy a VM
> + # 2. Call queryAsyncJobResult API with jobid of previous step
> + # 3. Verify that queryAsyncJobResult returns jobinstanceid
> +
> + """
> + # Step 1
> +
> --- End diff --
>
> Fixed pep8 issues.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cloudstack pull request: CLOUDSTACK-8664: Verify if queryAsyncJobR...
Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/619#discussion_r35508814
--- Diff: test/integration/testpaths/testpath_queryAsyncJobResult.py ---
@@ -0,0 +1,133 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" Test case to check if queryAsyncJobResult returns jobinstanceid
+"""
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ VirtualMachine,
+ )
+from marvin.lib.common import (get_domain,
+ get_zone,
+ get_template,
+ )
+
+from marvin.cloudstackAPI import queryAsyncJobResult
+
+class TestJobinstanceid(cloudstackTestCase):
+
+ @classmethod
+ def setUpClass(cls):
+ testClient = super(TestJobinstanceid, cls).getClsTestClient()
+ cls.apiclient = testClient.getApiClient()
+ cls.testdata = testClient.getParsedTestDataConfig()
+
+ cls.hypervisor = cls.testClient.getHypervisorInfo()
+ # Get Zone, Domain and templates
+ cls.domain = get_domain(cls.apiclient)
+ cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+
+ cls.template = get_template(
+ cls.apiclient,
+ cls.zone.id,
+ cls.testdata["ostype"])
+
+ cls._cleanup = []
+
+ try:
+
+ # Create an account
+ cls.account = Account.create(
+ cls.apiclient,
+ cls.testdata["account"],
+ domainid=cls.domain.id
+ )
+ # Create user api client of the account
+ cls.userapiclient = testClient.getUserApiClient(
+ UserName=cls.account.name,
+ DomainName=cls.account.domain
+ )
+
+ # Create Service offering
+ cls.service_offering = ServiceOffering.create(
+ cls.apiclient,
+ cls.testdata["service_offering"],
+ )
+
+ cls._cleanup = [
+ cls.account,
+ cls.service_offering,
+ ]
+ except Exception as e:
+ cls.tearDownClass()
+ raise e
+ return
+
+
+ @classmethod
+ def tearDownClass(cls):
+ try:
+ cleanup_resources(cls.apiclient, cls._cleanup)
+ except Exception as e:
+ raise Exception("Warning: Exception during cleanup : %s" % e)
+
+ def setUp(self):
+ self.apiclient = self.testClient.getApiClient()
+ self.dbclient = self.testClient.getDbConnection()
+ self.cleanup = []
+
+ def tearDown(self):
+ try:
+ cleanup_resources(self.apiclient, self.cleanup)
+ except Exception as e:
+ raise Exception("Warning: Exception during cleanup : %s" % e)
+ return
+
+ @attr(tags=["advanced", "basic"], required_hardware="false")
+ def test_queryAsyncJobResult_jobinstanceid(self):
+ """ Test queryAsyncJobResult api return jobinstanceid
+
+ # 1. Deploy a VM
+ # 2. Call queryAsyncJobResult API with jobid of previous step
+ # 3. Verify that queryAsyncJobResult returns jobinstanceid
+
+ """
+ # Step 1
+
--- End diff --
Fixed pep8 issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8664: Verify if queryAsyncJobR...
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/619#discussion_r35507858
--- Diff: test/integration/testpaths/testpath_queryAsyncJobResult.py ---
@@ -0,0 +1,133 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" Test case to check if queryAsyncJobResult returns jobinstanceid
+"""
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ VirtualMachine,
+ )
+from marvin.lib.common import (get_domain,
+ get_zone,
+ get_template,
+ )
+
+from marvin.cloudstackAPI import queryAsyncJobResult
+
+class TestJobinstanceid(cloudstackTestCase):
+
+ @classmethod
+ def setUpClass(cls):
+ testClient = super(TestJobinstanceid, cls).getClsTestClient()
+ cls.apiclient = testClient.getApiClient()
+ cls.testdata = testClient.getParsedTestDataConfig()
+
+ cls.hypervisor = cls.testClient.getHypervisorInfo()
+ # Get Zone, Domain and templates
+ cls.domain = get_domain(cls.apiclient)
+ cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+
+ cls.template = get_template(
+ cls.apiclient,
+ cls.zone.id,
+ cls.testdata["ostype"])
+
+ cls._cleanup = []
+
+ try:
+
+ # Create an account
+ cls.account = Account.create(
+ cls.apiclient,
+ cls.testdata["account"],
+ domainid=cls.domain.id
+ )
+ # Create user api client of the account
+ cls.userapiclient = testClient.getUserApiClient(
+ UserName=cls.account.name,
+ DomainName=cls.account.domain
+ )
+
+ # Create Service offering
+ cls.service_offering = ServiceOffering.create(
+ cls.apiclient,
+ cls.testdata["service_offering"],
+ )
+
+ cls._cleanup = [
+ cls.account,
+ cls.service_offering,
+ ]
+ except Exception as e:
+ cls.tearDownClass()
+ raise e
+ return
+
+
+ @classmethod
+ def tearDownClass(cls):
+ try:
+ cleanup_resources(cls.apiclient, cls._cleanup)
+ except Exception as e:
+ raise Exception("Warning: Exception during cleanup : %s" % e)
+
+ def setUp(self):
+ self.apiclient = self.testClient.getApiClient()
+ self.dbclient = self.testClient.getDbConnection()
+ self.cleanup = []
+
+ def tearDown(self):
+ try:
+ cleanup_resources(self.apiclient, self.cleanup)
+ except Exception as e:
+ raise Exception("Warning: Exception during cleanup : %s" % e)
+ return
+
+ @attr(tags=["advanced", "basic"], required_hardware="false")
+ def test_queryAsyncJobResult_jobinstanceid(self):
+ """ Test queryAsyncJobResult api return jobinstanceid
+
+ # 1. Deploy a VM
+ # 2. Call queryAsyncJobResult API with jobid of previous step
+ # 3. Verify that queryAsyncJobResult returns jobinstanceid
+
+ """
+ # Step 1
+
--- End diff --
Please fix pep8 issues
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8664: Verify if queryAsyncJobR...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/619
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8664: Verify if queryAsyncJobR...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/619#issuecomment-125107406
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---