You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/01 01:52:26 UTC

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10723: feat: test databases connection api

codecov-commenter edited a comment on pull request #10723:
URL: https://github.com/apache/incubator-superset/pull/10723#issuecomment-683239330


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10723?src=pr&el=h1) Report
   > Merging [#10723](https://codecov.io/gh/apache/incubator-superset/pull/10723?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/cd144b68ac2168231346d3980748a406b0a14812?el=desc) will **increase** coverage by `1.20%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10723/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10723?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10723      +/-   ##
   ==========================================
   + Coverage   60.28%   61.49%   +1.20%     
   ==========================================
     Files         360      429      +69     
     Lines       23223    13954    -9269     
     Branches        0     3555    +3555     
   ==========================================
   - Hits        14001     8581    -5420     
   + Misses       9222     5186    -4036     
   - Partials        0      187     +187     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `61.49% <ø> (?)` | |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10723?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/teradata.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RlcmFkYXRhLnB5) | | |
   | [superset/utils/logging\_configurator.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nZ2luZ19jb25maWd1cmF0b3IucHk=) | | |
   | [superset/datasets/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | | |
   | [.../versions/6c7537a6004a\_models\_for\_email\_reports.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy82Yzc1MzdhNjAwNGFfbW9kZWxzX2Zvcl9lbWFpbF9yZXBvcnRzLnB5) | | |
   | [superset/migrations/versions/b347b202819b\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iMzQ3YjIwMjgxOWJfLnB5) | | |
   | [...ersions/def97f26fdfb\_add\_index\_to\_tagged\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kZWY5N2YyNmZkZmJfYWRkX2luZGV4X3RvX3RhZ2dlZF9vYmplY3QucHk=) | | |
   | [...rsions/289ce07647b\_add\_encrypted\_password\_field.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yODljZTA3NjQ3Yl9hZGRfZW5jcnlwdGVkX3Bhc3N3b3JkX2ZpZWxkLnB5) | | |
   | [superset/datasets/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZGVsZXRlLnB5) | | |
   | [superset/datasets/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvc2NoZW1hcy5weQ==) | | |
   | [superset/views/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZmlsdGVycy5weQ==) | | |
   | ... and [776 more](https://codecov.io/gh/apache/incubator-superset/pull/10723/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10723?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10723?src=pr&el=footer). Last update [cd144b6...9794ebd](https://codecov.io/gh/apache/incubator-superset/pull/10723?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org