You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by cc...@apache.org on 2006/12/11 09:15:44 UTC
svn commit: r485548 -
/geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml
Author: ccardona
Date: Mon Dec 11 00:15:43 2006
New Revision: 485548
URL: http://svn.apache.org/viewvc?view=rev&rev=485548
Log:
Added <version> to Activation and JavaMail specs to fix the 'Failed to validate POM' warning when building G.
Modified:
geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml
Modified: geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml
URL: http://svn.apache.org/viewvc/geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml?view=diff&rev=485548&r1=485547&r2=485548
==============================================================================
--- geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml (original)
+++ geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml Mon Dec 11 00:15:43 2006
@@ -39,11 +39,13 @@
<dependency>
<groupId>org.apache.geronimo.specs</groupId>
<artifactId>geronimo-activation_1.1_spec</artifactId>
+ <version>1.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.specs</groupId>
<artifactId>geronimo-javamail_1.4_spec</artifactId>
+ <version>1.0-SNAPSHOT</version>
</dependency>
</dependencies>
Re: svn commit: r485548 - /geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml
Posted by Jason Dillon <ja...@planet57.com>.
On Dec 11, 2006, at 1:26 AM, Christopher M. Cardona wrote:
> When we updated to JavaMail 1.4 and Activation 1.1 we got this
> warning message when building trunk:
>
> [WARNING] POM for 'org.apache.geronimo.javamail:geronimo-
> javamail_1.4_provider:pom:1.0-SNAPSHOT:compile' is invalid. It will
> be ignored for artifact resolution.
> Reason: Failed to validate POM
>
> The reason for this warning was it couldn't resolve the version for
> the said specs so I added it. I already published a new snapshot
> with these changes that's why we don't get this problem anymore but
> I forgot to update the source.
Um, if mvn could not resolve the version for these artifacts, then it
would have stopped the build with an error. This warning means that
it was able to resolve the artifact, but if found a pom with it which
was not valid, probably an m1 generated pom instead of an m2 pom.
I really don't see how adding version details to the child module's
pom helped this in any way.
> Thanks for the pointers. Not sure if we have conventions on
> creating properties but if I create 'javamail14Version' and
> 'activation11Version' in the parent pom will that work for you?
I was not referring to properties at all. Maven 2 has a
dependencyManangement section which is intented to hold version
details for child modules. If you really need to add these version
elements, then add them to the parent's dependencyManagement section,
so that the child poms can be free from version details.
Please do not not add version properties. I have been removing most
of them that I find and converting them to dependnecyManagement
entries as they should be. Properties for versions should not be
used IMO, except rarely, when using Maven 2.
--jason
Re: svn commit: r485548 - /geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml
Posted by "Christopher M. Cardona" <ch...@gmail.com>.
When we updated to JavaMail 1.4 and Activation 1.1 we got this warning
message when building trunk:
[WARNING] POM for
'org.apache.geronimo.javamail:geronimo-javamail_1.4_provider:pom:1.0-SNAPSHOT:compile'
is invalid. It will be ignored for artifact resolution.
Reason: Failed to validate POM
The reason for this warning was it couldn't resolve the version for the
said specs so I added it. I already published a new snapshot with these
changes that's why we don't get this problem anymore but I forgot to
update the source.
Thanks for the pointers. Not sure if we have conventions on creating
properties but if I create 'javamail14Version' and 'activation11Version'
in the parent pom will that work for you?
Thanks,
chris
Jason Dillon wrote:
> Why are these not in the top-level javamail pom? This was building
> fine for me as it was... or did someone recently change it to break
> things?
>
> Anyways, version details should probably be in the top-level pom, not
> in child poms, especially for a small project like this.
>
> --jason
>
>
> On Dec 11, 2006, at 12:15 AM, ccardona@apache.org wrote:
>
>> Author: ccardona
>> Date: Mon Dec 11 00:15:43 2006
>> New Revision: 485548
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=485548
>> Log:
>> Added <version> to Activation and JavaMail specs to fix the 'Failed
>> to validate POM' warning when building G.
>>
>> Modified:
>> geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml
>>
>> Modified: geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml?view=diff&rev=485548&r1=485547&r2=485548
>>
>> ==============================================================================
>>
>> --- geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml
>> (original)
>> +++ geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml
>> Mon Dec 11 00:15:43 2006
>> @@ -39,11 +39,13 @@
>> <dependency>
>> <groupId>org.apache.geronimo.specs</groupId>
>> <artifactId>geronimo-activation_1.1_spec</artifactId>
>> + <version>1.0-SNAPSHOT</version>
>> </dependency>
>>
>> <dependency>
>> <groupId>org.apache.geronimo.specs</groupId>
>> <artifactId>geronimo-javamail_1.4_spec</artifactId>
>> + <version>1.0-SNAPSHOT</version>
>> </dependency>
>>
>> </dependencies>
>>
>>
>
>
Re: svn commit: r485548 - /geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml
Posted by Jason Dillon <ja...@planet57.com>.
Why are these not in the top-level javamail pom? This was building
fine for me as it was... or did someone recently change it to break
things?
Anyways, version details should probably be in the top-level pom, not
in child poms, especially for a small project like this.
--jason
On Dec 11, 2006, at 12:15 AM, ccardona@apache.org wrote:
> Author: ccardona
> Date: Mon Dec 11 00:15:43 2006
> New Revision: 485548
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=485548
> Log:
> Added <version> to Activation and JavaMail specs to fix the 'Failed
> to validate POM' warning when building G.
>
> Modified:
> geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml
>
> Modified: geronimo/javamail/trunk/geronimo-javamail_1.4_provider/
> pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/javamail/trunk/geronimo-
> javamail_1.4_provider/pom.xml?view=diff&rev=485548&r1=485547&r2=485548
> ======================================================================
> ========
> --- geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml
> (original)
> +++ geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml
> Mon Dec 11 00:15:43 2006
> @@ -39,11 +39,13 @@
> <dependency>
> <groupId>org.apache.geronimo.specs</groupId>
> <artifactId>geronimo-activation_1.1_spec</artifactId>
> + <version>1.0-SNAPSHOT</version>
> </dependency>
>
> <dependency>
> <groupId>org.apache.geronimo.specs</groupId>
> <artifactId>geronimo-javamail_1.4_spec</artifactId>
> + <version>1.0-SNAPSHOT</version>
> </dependency>
>
> </dependencies>
>
>
Re: svn commit: r485548 - /geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml
Posted by Jason Dillon <ja...@planet57.com>.
Why are these not in the top-level javamail pom? This was building
fine for me as it was... or did someone recently change it to break
things?
Anyways, version details should probably be in the top-level pom, not
in child poms, especially for a small project like this.
--jason
On Dec 11, 2006, at 12:15 AM, ccardona@apache.org wrote:
> Author: ccardona
> Date: Mon Dec 11 00:15:43 2006
> New Revision: 485548
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=485548
> Log:
> Added <version> to Activation and JavaMail specs to fix the 'Failed
> to validate POM' warning when building G.
>
> Modified:
> geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml
>
> Modified: geronimo/javamail/trunk/geronimo-javamail_1.4_provider/
> pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/javamail/trunk/geronimo-
> javamail_1.4_provider/pom.xml?view=diff&rev=485548&r1=485547&r2=485548
> ======================================================================
> ========
> --- geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml
> (original)
> +++ geronimo/javamail/trunk/geronimo-javamail_1.4_provider/pom.xml
> Mon Dec 11 00:15:43 2006
> @@ -39,11 +39,13 @@
> <dependency>
> <groupId>org.apache.geronimo.specs</groupId>
> <artifactId>geronimo-activation_1.1_spec</artifactId>
> + <version>1.0-SNAPSHOT</version>
> </dependency>
>
> <dependency>
> <groupId>org.apache.geronimo.specs</groupId>
> <artifactId>geronimo-javamail_1.4_spec</artifactId>
> + <version>1.0-SNAPSHOT</version>
> </dependency>
>
> </dependencies>
>
>