You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/07 02:59:55 UTC
[GitHub] [incubator-seatunnel] wsyhj opened a new pull request, #1812: added security desensitization transform
wsyhj opened a new pull request, #1812:
URL: https://github.com/apache/incubator-seatunnel/pull/1812
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wsyhj commented on a diff in pull request #1812: added security desensitization transform
Posted by GitBox <gi...@apache.org>.
wsyhj commented on code in PR #1812:
URL: https://github.com/apache/incubator-seatunnel/pull/1812#discussion_r868705190
##########
seatunnel-transforms/seatunnel-transforms-spark/seatunnel-transform-spark-encrypt-phone/introduction.md:
##########
@@ -0,0 +1,19 @@
+### 目的
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wsyhj commented on pull request #1812: added security desensitization transform
Posted by GitBox <gi...@apache.org>.
wsyhj commented on PR #1812:
URL: https://github.com/apache/incubator-seatunnel/pull/1812#issuecomment-1120850973
> @wsyhj Please resolve the conflicting files, thanks.
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wsyhj commented on pull request #1812: added security desensitization transform
Posted by GitBox <gi...@apache.org>.
wsyhj commented on PR #1812:
URL: https://github.com/apache/incubator-seatunnel/pull/1812#issuecomment-1129824436
> I agree with CalvinKirs, it might be better to provide a general encrypt plugin rather than provide phone encrypt, id card encrypt...etc.
I got ,tks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wsyhj commented on pull request #1812: added security desensitization transform
Posted by GitBox <gi...@apache.org>.
wsyhj commented on PR #1812:
URL: https://github.com/apache/incubator-seatunnel/pull/1812#issuecomment-1123597105
> Maybe after this PR merge, you can add one document in `docs/en/transform` directory. But should follow the template. After this, your Transform will show on our website.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wsyhj commented on a diff in pull request #1812: added security desensitization transform
Posted by GitBox <gi...@apache.org>.
wsyhj commented on code in PR #1812:
URL: https://github.com/apache/incubator-seatunnel/pull/1812#discussion_r870187119
##########
seatunnel-transforms/seatunnel-transforms-spark/seatunnel-transform-spark-encrypt-phone/src/main/resources/META-INF/services/org.apache.seatunnel.spark.BaseSparkTransform:
##########
@@ -0,0 +1 @@
+org.apache.seatunnel.spark.transform.EncryptedPhone
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wsyhj commented on pull request #1812: added security desensitization transform
Posted by GitBox <gi...@apache.org>.
wsyhj commented on PR #1812:
URL: https://github.com/apache/incubator-seatunnel/pull/1812#issuecomment-1125607761
> LGTM, looking forward your next contribute!
tks，but the request is suspend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on a diff in pull request #1812: added security desensitization transform
Posted by GitBox <gi...@apache.org>.
BenJFan commented on code in PR #1812:
URL: https://github.com/apache/incubator-seatunnel/pull/1812#discussion_r867892474
##########
seatunnel-transforms/seatunnel-transforms-spark/seatunnel-transform-spark-encrypt-phone/introduction.md:
##########
@@ -0,0 +1,19 @@
+### 目的
Review Comment:
Please use English to describe it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1812: added security desensitization transform
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1812:
URL: https://github.com/apache/incubator-seatunnel/pull/1812#issuecomment-1127535307
I agree with CalvinKirs, it might be better to provide a general encrypt plugin rather than provide phone encrypt, id card encrypt...etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1812: added security desensitization transform
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on PR #1812:
URL: https://github.com/apache/incubator-seatunnel/pull/1812#issuecomment-1120148039
@wsyhj Please resolve the conflicting files, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1812: added security desensitization transform
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1812:
URL: https://github.com/apache/incubator-seatunnel/pull/1812#issuecomment-1120958665
Maybe after this PR merge, you can add one document in `docs/en/transform` directory. But should follow the template. After this, your Transform will show on our website.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on a diff in pull request #1812: added security desensitization transform
Posted by GitBox <gi...@apache.org>.
BenJFan commented on code in PR #1812:
URL: https://github.com/apache/incubator-seatunnel/pull/1812#discussion_r867296809
##########
seatunnel-transforms/seatunnel-transforms-spark/seatunnel-transform-spark-encrypt-phone/src/main/resources/META-INF/services/org.apache.seatunnel.spark.BaseSparkTransform:
##########
@@ -0,0 +1 @@
+org.apache.seatunnel.spark.transform.EncryptedPhone
Review Comment:
Please add Apache License header, and add one empty end line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1812: added security desensitization transform
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1812:
URL: https://github.com/apache/incubator-seatunnel/pull/1812#issuecomment-1120124198
Can you add doc to introduce this transform?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wsyhj commented on a diff in pull request #1812: added security desensitization transform
Posted by GitBox <gi...@apache.org>.
wsyhj commented on code in PR #1812:
URL: https://github.com/apache/incubator-seatunnel/pull/1812#discussion_r867624269
##########
seatunnel-transforms/seatunnel-transforms-spark/seatunnel-transform-spark-encrypt-phone/src/main/resources/META-INF/services/org.apache.seatunnel.spark.BaseSparkTransform:
##########
@@ -0,0 +1 @@
+org.apache.seatunnel.spark.transform.EncryptedPhone
Review Comment:
Need to re request？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on a diff in pull request #1812: added security desensitization transform
Posted by GitBox <gi...@apache.org>.
BenJFan commented on code in PR #1812:
URL: https://github.com/apache/incubator-seatunnel/pull/1812#discussion_r867716445
##########
seatunnel-transforms/seatunnel-transforms-spark/seatunnel-transform-spark-encrypt-phone/src/main/resources/META-INF/services/org.apache.seatunnel.spark.BaseSparkTransform:
##########
@@ -0,0 +1 @@
+org.apache.seatunnel.spark.transform.EncryptedPhone
Review Comment:
Just push in `wsyhj:dev` branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wsyhj commented on pull request #1812: added security desensitization transform
Posted by GitBox <gi...@apache.org>.
wsyhj commented on PR #1812:
URL: https://github.com/apache/incubator-seatunnel/pull/1812#issuecomment-1120852265
> Can you add doc to introduce this transform?
refer to introduction.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X closed pull request #1812: added security desensitization transform
Posted by GitBox <gi...@apache.org>.
Hisoka-X closed pull request #1812: added security desensitization transform
URL: https://github.com/apache/incubator-seatunnel/pull/1812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org