You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2015/04/28 00:29:31 UTC
Review Request 33601: Ambari API should support querying metric
values with aggregation type (max, min, avg and sum )
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33601/
-----------------------------------------------------------
Review request for Ambari, Dmytro Sen, Jaimin Jetly, Sumit Mohanty, and Tom Beerbower.
Bugs: AMBARI-10779
https://issues.apache.org/jira/browse/AMBARI-10779
Repository: ambari
Description
-------
Each metric present in metrics descriptor should support avg, min, max and sum.
Ambari serviceComponent API endpoint should support querying metrics with the aggregation types (min, max, avg and sum)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProviderProxy.java d2cd959
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSComponentPropertyProvider.java 1fb0869
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 77ffbc1
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java 052f86c
ambari-server/src/test/resources/ams/aggregate_component_metric.json PRE-CREATION
ambari-server/src/test/resources/ams/multiple_component_metrics.json 3d231fa
Diff: https://reviews.apache.org/r/33601/diff/
Testing
-------
Manually verified. Related unit test pass.
Thanks,
Sid Wagle
Re: Review Request 33601: Ambari API should support querying metric
values with aggregation type (max, min, avg and sum )
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33601/#review81746
-----------------------------------------------------------
Ship it!
Minor comment...
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProviderProxy.java
<https://reviews.apache.org/r/33601/#comment132182>
Doesn't look like this is needed.
- Tom Beerbower
On April 27, 2015, 10:39 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33601/
> -----------------------------------------------------------
>
> (Updated April 27, 2015, 10:39 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Jaimin Jetly, Sumit Mohanty, and Tom Beerbower.
>
>
> Bugs: AMBARI-10779
> https://issues.apache.org/jira/browse/AMBARI-10779
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Each metric present in metrics descriptor should support avg, min, max and sum.
> Ambari serviceComponent API endpoint should support querying metrics with the aggregation types (min, max, avg and sum)
>
> Notes:
> Any metricName._<validFunction[sum,max,min,avg]> is supported on Component metrics.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProviderProxy.java d2cd959
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSComponentPropertyProvider.java 1fb0869
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 77ffbc1
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java 052f86c
> ambari-server/src/test/resources/ams/aggregate_component_metric.json PRE-CREATION
> ambari-server/src/test/resources/ams/multiple_component_metrics.json 3d231fa
>
> Diff: https://reviews.apache.org/r/33601/diff/
>
>
> Testing
> -------
>
> Manually verified. Related unit test pass.
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 33601: Ambari API should support querying metric
values with aggregation type (max, min, avg and sum )
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33601/#review81744
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On April 27, 2015, 10:39 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33601/
> -----------------------------------------------------------
>
> (Updated April 27, 2015, 10:39 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Jaimin Jetly, Sumit Mohanty, and Tom Beerbower.
>
>
> Bugs: AMBARI-10779
> https://issues.apache.org/jira/browse/AMBARI-10779
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Each metric present in metrics descriptor should support avg, min, max and sum.
> Ambari serviceComponent API endpoint should support querying metrics with the aggregation types (min, max, avg and sum)
>
> Notes:
> Any metricName._<validFunction[sum,max,min,avg]> is supported on Component metrics.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProviderProxy.java d2cd959
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSComponentPropertyProvider.java 1fb0869
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 77ffbc1
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java 052f86c
> ambari-server/src/test/resources/ams/aggregate_component_metric.json PRE-CREATION
> ambari-server/src/test/resources/ams/multiple_component_metrics.json 3d231fa
>
> Diff: https://reviews.apache.org/r/33601/diff/
>
>
> Testing
> -------
>
> Manually verified. Related unit test pass.
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 33601: Ambari API should support querying metric
values with aggregation type (max, min, avg and sum )
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33601/
-----------------------------------------------------------
(Updated April 27, 2015, 10:39 p.m.)
Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Jaimin Jetly, Sumit Mohanty, and Tom Beerbower.
Bugs: AMBARI-10779
https://issues.apache.org/jira/browse/AMBARI-10779
Repository: ambari
Description (updated)
-------
Each metric present in metrics descriptor should support avg, min, max and sum.
Ambari serviceComponent API endpoint should support querying metrics with the aggregation types (min, max, avg and sum)
Notes:
Any metricName._<validFunction[sum,max,min,avg]> is supported on Component metrics.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProviderProxy.java d2cd959
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSComponentPropertyProvider.java 1fb0869
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 77ffbc1
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java 052f86c
ambari-server/src/test/resources/ams/aggregate_component_metric.json PRE-CREATION
ambari-server/src/test/resources/ams/multiple_component_metrics.json 3d231fa
Diff: https://reviews.apache.org/r/33601/diff/
Testing
-------
Manually verified. Related unit test pass.
Thanks,
Sid Wagle