You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/04/22 16:10:50 UTC

[GitHub] [thrift] fishy opened a new pull request #2110: THRIFT-5183: Don't try to read next frame in THeaderTransport.Read

fishy opened a new pull request #2110:
URL: https://github.com/apache/thrift/pull/2110


   Client: go
   
   Trying to read the next frame will likely cause the Read call blocking
   indefinitely and eventually lead to timeout. See the JIRA ticket for
   more context.
   
   <!-- Explain the changes in the pull request below: -->
     
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, add ` [skip ci]` at the end of your pull request to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] dcelasun commented on pull request #2110: THRIFT-5183: Don't try to read next frame in THeaderTransport.Read

Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2110:
URL: https://github.com/apache/thrift/pull/2110#issuecomment-618662755


   Nice catch @fishy! Could you maybe add a test so this won't regress in a potential refactor down the line? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] fishy commented on issue #2110: THRIFT-5183: Don't try to read next frame in THeaderTransport.Read

Posted by GitBox <gi...@apache.org>.
fishy commented on issue #2110:
URL: https://github.com/apache/thrift/pull/2110#issuecomment-617877222


   @dcelasun :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] fishy commented on pull request #2110: THRIFT-5183: Don't try to read next frame in THeaderTransport.Read

Posted by GitBox <gi...@apache.org>.
fishy commented on pull request #2110:
URL: https://github.com/apache/thrift/pull/2110#issuecomment-618739157


   @dcelasun Test added.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] dcelasun commented on pull request #2110: THRIFT-5183: Don't try to read next frame in THeaderTransport.Read

Posted by GitBox <gi...@apache.org>.
dcelasun commented on pull request #2110:
URL: https://github.com/apache/thrift/pull/2110#issuecomment-618831826


   Thanks! CI failures are unrelated so I'm merging this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org