[GitHub] [incubator-tvm] giuseros commented on a change in pull request #5980: Fixed point multiplication improvements for AArch64

[GitBox <gi...@apache.org>]

giuseros commented on a change in pull request #5980:
URL: https://github.com/apache/incubator-tvm/pull/5980#discussion_r454404831



##########
File path: include/tvm/tir/builtin.h
##########
@@ -92,6 +92,14 @@ TVM_DLL const Op& shift_right();
  */
 TVM_DLL const Op& large_uint_imm();
 
+/*!
+ * \brief Execute a multiplication between two Q-numbers x and y
+ * followed by a right shift s
+ * The default rounding rule is to the nearest value, rounding half up
+ * (i.e., round(x.1) = x and round (x.5) = x+1)
+ */
+TVM_DLL const Op& qmuls();

Review comment:
       Should we use this thread to discuss naming? The problem with using `fixed_point_multipliy` for the intrinsic is that it describes an operation which is more general than the `fixed_point_multiply` we do in Relay. So `fixed_point_multiply(x,m,s) = qmuls(x, m, 31, s)`. We might call it `q_multiply_shift`? Or `q_multiply_scale`? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org