You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/06 03:37:30 UTC

[GitHub] [pulsar-client-go] billowqiu commented on a diff in pull request #772: Add consumer state check when request commands

billowqiu commented on code in PR #772:
URL: https://github.com/apache/pulsar-client-go/pull/772#discussion_r866467199


##########
pulsar/consumer_partition.go:
##########
@@ -477,6 +490,10 @@ func (pc *partitionConsumer) clearMessageChannels() {
 }
 
 func (pc *partitionConsumer) internalAck(req *ackRequest) {
+	if state := pc.getConsumerState(); state == consumerClosed || state == consumerClosing {

Review Comment:
   这里判断已经卡住了，要在外面Ack接口地方判断



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org