You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Olga Natkovich (JIRA)" <ji...@apache.org> on 2009/10/24 00:55:59 UTC
[jira] Created: (PIG-1050) FINDBUGS: DLS_DEAD_LOCAL_STORE: Dead
store to local variable
FINDBUGS: DLS_DEAD_LOCAL_STORE: Dead store to local variable
------------------------------------------------------------
Key: PIG-1050
URL: https://issues.apache.org/jira/browse/PIG-1050
Project: Pig
Issue Type: Improvement
Reporter: Olga Natkovich
Assignee: Olga Natkovich
DLS Dead store to $L9 in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.partitioners.SkewedPartitioner.getPartition(PigNullableWritable, Writable, int)
DLS Dead store to sleepTime in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigCombiner$Combine.configure(JobConf)
DLS Dead store to sleepTime in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigMapReduce$Reduce.configure(JobConf)
DLS Dead store to ret in org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.getNext(DataBag)
DLS Dead store to count in org.apache.pig.impl.logicalLayer.LOForEach.updateAliasCount(Map, String)
DLS Dead store to newArgs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.insertCastsForUDF(LOUserFunc, Schema, Schema)
DLS Dead store to fs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOAnd)
DLS Dead store to fsList in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOCross)
DLS Dead store to fs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOOr)
DLS Dead store to foreachPlan in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.insertCastForEachInBetweenIfNecessary(LogicalOperator, LogicalOperator, Schema)
DLS Dead store to inputs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOCross)
DLS Dead store to list in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LODistinct)
DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOFilter)
DLS Dead store to flattens in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOForEach)
DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOSplit)
DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOSplitOutput)
DLS Dead store to $L3 in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOUnion)
DLS Dead store to pigClassLoader in org.apache.pig.impl.util.JarManager.createJar(OutputStream, List, PigContext)
DLS Dead store to buffer in org.apache.pig.Main.getVersionString()
DLS Dead store to converter in org.apache.pig.tools.streams.StreamGenerator.createAndShowGUI()
DLS Dead store to c in org.apache.tools.bzip2r.CBZip2OutputStream.med3(char, char, char)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1050) FINDBUGS: DLS_DEAD_LOCAL_STORE: Dead
store to local variable
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-1050:
--------------------------------
Attachment: PIG-1050.patch
> FINDBUGS: DLS_DEAD_LOCAL_STORE: Dead store to local variable
> ------------------------------------------------------------
>
> Key: PIG-1050
> URL: https://issues.apache.org/jira/browse/PIG-1050
> Project: Pig
> Issue Type: Improvement
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Attachments: PIG-1050.patch
>
>
> DLS Dead store to $L9 in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.partitioners.SkewedPartitioner.getPartition(PigNullableWritable, Writable, int)
> DLS Dead store to sleepTime in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigCombiner$Combine.configure(JobConf)
> DLS Dead store to sleepTime in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigMapReduce$Reduce.configure(JobConf)
> DLS Dead store to ret in org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.getNext(DataBag)
> DLS Dead store to count in org.apache.pig.impl.logicalLayer.LOForEach.updateAliasCount(Map, String)
> DLS Dead store to newArgs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.insertCastsForUDF(LOUserFunc, Schema, Schema)
> DLS Dead store to fs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOAnd)
> DLS Dead store to fsList in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOCross)
> DLS Dead store to fs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOOr)
> DLS Dead store to foreachPlan in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.insertCastForEachInBetweenIfNecessary(LogicalOperator, LogicalOperator, Schema)
> DLS Dead store to inputs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOCross)
> DLS Dead store to list in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LODistinct)
> DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOFilter)
> DLS Dead store to flattens in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOForEach)
> DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOSplit)
> DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOSplitOutput)
> DLS Dead store to $L3 in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOUnion)
> DLS Dead store to pigClassLoader in org.apache.pig.impl.util.JarManager.createJar(OutputStream, List, PigContext)
> DLS Dead store to buffer in org.apache.pig.Main.getVersionString()
> DLS Dead store to converter in org.apache.pig.tools.streams.StreamGenerator.createAndShowGUI()
> DLS Dead store to c in org.apache.tools.bzip2r.CBZip2OutputStream.med3(char, char, char)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1050) FINDBUGS: DLS_DEAD_LOCAL_STORE: Dead
store to local variable
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-1050:
--------------------------------
Status: Patch Available (was: Open)
> FINDBUGS: DLS_DEAD_LOCAL_STORE: Dead store to local variable
> ------------------------------------------------------------
>
> Key: PIG-1050
> URL: https://issues.apache.org/jira/browse/PIG-1050
> Project: Pig
> Issue Type: Improvement
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Attachments: PIG-1050.patch
>
>
> DLS Dead store to $L9 in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.partitioners.SkewedPartitioner.getPartition(PigNullableWritable, Writable, int)
> DLS Dead store to sleepTime in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigCombiner$Combine.configure(JobConf)
> DLS Dead store to sleepTime in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigMapReduce$Reduce.configure(JobConf)
> DLS Dead store to ret in org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.getNext(DataBag)
> DLS Dead store to count in org.apache.pig.impl.logicalLayer.LOForEach.updateAliasCount(Map, String)
> DLS Dead store to newArgs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.insertCastsForUDF(LOUserFunc, Schema, Schema)
> DLS Dead store to fs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOAnd)
> DLS Dead store to fsList in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOCross)
> DLS Dead store to fs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOOr)
> DLS Dead store to foreachPlan in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.insertCastForEachInBetweenIfNecessary(LogicalOperator, LogicalOperator, Schema)
> DLS Dead store to inputs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOCross)
> DLS Dead store to list in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LODistinct)
> DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOFilter)
> DLS Dead store to flattens in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOForEach)
> DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOSplit)
> DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOSplitOutput)
> DLS Dead store to $L3 in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOUnion)
> DLS Dead store to pigClassLoader in org.apache.pig.impl.util.JarManager.createJar(OutputStream, List, PigContext)
> DLS Dead store to buffer in org.apache.pig.Main.getVersionString()
> DLS Dead store to converter in org.apache.pig.tools.streams.StreamGenerator.createAndShowGUI()
> DLS Dead store to c in org.apache.tools.bzip2r.CBZip2OutputStream.med3(char, char, char)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1050) FINDBUGS: DLS_DEAD_LOCAL_STORE: Dead
store to local variable
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770169#action_12770169 ]
Daniel Dai commented on PIG-1050:
---------------------------------
+1
> FINDBUGS: DLS_DEAD_LOCAL_STORE: Dead store to local variable
> ------------------------------------------------------------
>
> Key: PIG-1050
> URL: https://issues.apache.org/jira/browse/PIG-1050
> Project: Pig
> Issue Type: Improvement
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Attachments: PIG-1050.patch
>
>
> DLS Dead store to $L9 in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.partitioners.SkewedPartitioner.getPartition(PigNullableWritable, Writable, int)
> DLS Dead store to sleepTime in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigCombiner$Combine.configure(JobConf)
> DLS Dead store to sleepTime in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigMapReduce$Reduce.configure(JobConf)
> DLS Dead store to ret in org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.getNext(DataBag)
> DLS Dead store to count in org.apache.pig.impl.logicalLayer.LOForEach.updateAliasCount(Map, String)
> DLS Dead store to newArgs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.insertCastsForUDF(LOUserFunc, Schema, Schema)
> DLS Dead store to fs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOAnd)
> DLS Dead store to fsList in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOCross)
> DLS Dead store to fs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOOr)
> DLS Dead store to foreachPlan in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.insertCastForEachInBetweenIfNecessary(LogicalOperator, LogicalOperator, Schema)
> DLS Dead store to inputs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOCross)
> DLS Dead store to list in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LODistinct)
> DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOFilter)
> DLS Dead store to flattens in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOForEach)
> DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOSplit)
> DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOSplitOutput)
> DLS Dead store to $L3 in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOUnion)
> DLS Dead store to pigClassLoader in org.apache.pig.impl.util.JarManager.createJar(OutputStream, List, PigContext)
> DLS Dead store to buffer in org.apache.pig.Main.getVersionString()
> DLS Dead store to converter in org.apache.pig.tools.streams.StreamGenerator.createAndShowGUI()
> DLS Dead store to c in org.apache.tools.bzip2r.CBZip2OutputStream.med3(char, char, char)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1050) FINDBUGS: DLS_DEAD_LOCAL_STORE: Dead
store to local variable
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-1050:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
patch committed
> FINDBUGS: DLS_DEAD_LOCAL_STORE: Dead store to local variable
> ------------------------------------------------------------
>
> Key: PIG-1050
> URL: https://issues.apache.org/jira/browse/PIG-1050
> Project: Pig
> Issue Type: Improvement
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Attachments: PIG-1050.patch
>
>
> DLS Dead store to $L9 in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.partitioners.SkewedPartitioner.getPartition(PigNullableWritable, Writable, int)
> DLS Dead store to sleepTime in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigCombiner$Combine.configure(JobConf)
> DLS Dead store to sleepTime in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigMapReduce$Reduce.configure(JobConf)
> DLS Dead store to ret in org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.getNext(DataBag)
> DLS Dead store to count in org.apache.pig.impl.logicalLayer.LOForEach.updateAliasCount(Map, String)
> DLS Dead store to newArgs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.insertCastsForUDF(LOUserFunc, Schema, Schema)
> DLS Dead store to fs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOAnd)
> DLS Dead store to fsList in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOCross)
> DLS Dead store to fs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOOr)
> DLS Dead store to foreachPlan in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.insertCastForEachInBetweenIfNecessary(LogicalOperator, LogicalOperator, Schema)
> DLS Dead store to inputs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOCross)
> DLS Dead store to list in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LODistinct)
> DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOFilter)
> DLS Dead store to flattens in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOForEach)
> DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOSplit)
> DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOSplitOutput)
> DLS Dead store to $L3 in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOUnion)
> DLS Dead store to pigClassLoader in org.apache.pig.impl.util.JarManager.createJar(OutputStream, List, PigContext)
> DLS Dead store to buffer in org.apache.pig.Main.getVersionString()
> DLS Dead store to converter in org.apache.pig.tools.streams.StreamGenerator.createAndShowGUI()
> DLS Dead store to c in org.apache.tools.bzip2r.CBZip2OutputStream.med3(char, char, char)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1050) FINDBUGS: DLS_DEAD_LOCAL_STORE: Dead
store to local variable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770252#action_12770252 ]
Hadoop QA commented on PIG-1050:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12423237/PIG-1050.patch
against trunk revision 829891.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/114/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/114/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/114/console
This message is automatically generated.
> FINDBUGS: DLS_DEAD_LOCAL_STORE: Dead store to local variable
> ------------------------------------------------------------
>
> Key: PIG-1050
> URL: https://issues.apache.org/jira/browse/PIG-1050
> Project: Pig
> Issue Type: Improvement
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Attachments: PIG-1050.patch
>
>
> DLS Dead store to $L9 in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.partitioners.SkewedPartitioner.getPartition(PigNullableWritable, Writable, int)
> DLS Dead store to sleepTime in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigCombiner$Combine.configure(JobConf)
> DLS Dead store to sleepTime in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigMapReduce$Reduce.configure(JobConf)
> DLS Dead store to ret in org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.getNext(DataBag)
> DLS Dead store to count in org.apache.pig.impl.logicalLayer.LOForEach.updateAliasCount(Map, String)
> DLS Dead store to newArgs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.insertCastsForUDF(LOUserFunc, Schema, Schema)
> DLS Dead store to fs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOAnd)
> DLS Dead store to fsList in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOCross)
> DLS Dead store to fs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOOr)
> DLS Dead store to foreachPlan in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.insertCastForEachInBetweenIfNecessary(LogicalOperator, LogicalOperator, Schema)
> DLS Dead store to inputs in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOCross)
> DLS Dead store to list in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LODistinct)
> DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOFilter)
> DLS Dead store to flattens in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOForEach)
> DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOSplit)
> DLS Dead store to input in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOSplitOutput)
> DLS Dead store to $L3 in org.apache.pig.impl.logicalLayer.validators.TypeCheckingVisitor.visit(LOUnion)
> DLS Dead store to pigClassLoader in org.apache.pig.impl.util.JarManager.createJar(OutputStream, List, PigContext)
> DLS Dead store to buffer in org.apache.pig.Main.getVersionString()
> DLS Dead store to converter in org.apache.pig.tools.streams.StreamGenerator.createAndShowGUI()
> DLS Dead store to c in org.apache.tools.bzip2r.CBZip2OutputStream.med3(char, char, char)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.