[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in pull request #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value.

[GitBox <gi...@apache.org>]

KomachiSion commented on a change in pull request #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value.
URL: https://github.com/apache/incubator-shardingsphere/pull/3288#discussion_r335336109
 
 

 ##########
 File path: sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql/execute/result/QueryResultUtil.java
 ##########
 @@ -135,4 +135,28 @@ private static Object getValueByColumnType(final ResultSet resultSet, final int
                 return resultSet.getObject(columnIndex);
         }
     }
+
+    private static Object getIntTypeValue(final ResultSet resultSet, final int columnIndex) throws SQLException {
 
 Review comment:
   I think the method can be remove

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services