You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Brock Noland <br...@cloudera.com> on 2012/10/18 17:08:23 UTC

Review Request: FLUME-1562: Logutils.getLogs could NPE

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7647/
-----------------------------------------------------------

Review request for Flume.


Description
-------

If we cannot list a log directory, which is checked before startup in the Log class, throw a good error message.


This addresses bug FLUME-1562.
    https://issues.apache.org/jira/browse/FLUME-1562


Diffs
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogUtils.java 13f7298 

Diff: https://reviews.apache.org/r/7647/diff/


Testing
-------


Thanks,

Brock Noland


Re: Review Request: FLUME-1562: Logutils.getLogs could NPE

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7647/#review12648
-----------------------------------------------------------

Ship it!


Ship It!

- Hari Shreedharan


On Oct. 18, 2012, 3:08 p.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7647/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2012, 3:08 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> If we cannot list a log directory, which is checked before startup in the Log class, throw a good error message.
> 
> 
> This addresses bug FLUME-1562.
>     https://issues.apache.org/jira/browse/FLUME-1562
> 
> 
> Diffs
> -----
> 
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogUtils.java 13f7298 
> 
> Diff: https://reviews.apache.org/r/7647/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brock Noland
> 
>


Re: Review Request: FLUME-1562: Logutils.getLogs could NPE

Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7647/#review13134
-----------------------------------------------------------

Ship it!


Ship It!

- Alexander Alten-Lorenz


On Oct. 18, 2012, 3:08 p.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7647/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2012, 3:08 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> If we cannot list a log directory, which is checked before startup in the Log class, throw a good error message.
> 
> 
> This addresses bug FLUME-1562.
>     https://issues.apache.org/jira/browse/FLUME-1562
> 
> 
> Diffs
> -----
> 
>   flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogUtils.java 13f7298 
> 
> Diff: https://reviews.apache.org/r/7647/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brock Noland
> 
>