You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/08 18:25:39 UTC
[GitHub] [arrow] paleolimbot commented on a diff in pull request #13555: ARROW-16715: [R] Bump default parquet version
paleolimbot commented on code in PR #13555:
URL: https://github.com/apache/arrow/pull/13555#discussion_r917048608
##########
r/tests/testthat/test-parquet.R:
##########
@@ -129,15 +129,51 @@ test_that("write_parquet() can truncate timestamps", {
expect_equal(as.data.frame(tab), as.data.frame(new))
})
-test_that("make_valid_version()", {
- expect_equal(make_valid_version("1.0"), ParquetVersionType$PARQUET_1_0)
- expect_equal(make_valid_version("2.0"), ParquetVersionType$PARQUET_2_0)
+test_that("make_valid_parquet_version()", {
+ expect_equal(
+ make_valid_parquet_version("1.0"),
+ ParquetVersionType$PARQUET_1_0
+ )
+ expect_deprecated(
+ expect_equal(
+ make_valid_parquet_version("2.0"),
+ ParquetVersionType$PARQUET_2_0
+ )
+ )
+ expect_equal(
+ make_valid_parquet_version("2.4"),
+ ParquetVersionType$PARQUET_2_4
+ )
+ expect_equal(
+ make_valid_parquet_version("2.6"),
+ ParquetVersionType$PARQUET_2_6
+ )
+ expect_equal(
+ make_valid_parquet_version("latest"),
+ ParquetVersionType$PARQUET_2_6
+ )
- expect_equal(make_valid_version(1), ParquetVersionType$PARQUET_1_0)
- expect_equal(make_valid_version(2), ParquetVersionType$PARQUET_2_0)
+ expect_equal(make_valid_parquet_version(1), ParquetVersionType$PARQUET_1_0)
+ expect_deprecated(
+ expect_equal(make_valid_parquet_version(2), ParquetVersionType$PARQUET_2_0)
+ )
+ expect_equal(make_valid_parquet_version(1.0), ParquetVersionType$PARQUET_1_0)
+ expect_equal(make_valid_parquet_version(2.4), ParquetVersionType$PARQUET_2_4)
+})
- expect_equal(make_valid_version(1.0), ParquetVersionType$PARQUET_1_0)
- expect_equal(make_valid_version(2.0), ParquetVersionType$PARQUET_2_0)
+test_that("make_valid_parquet_version() input validation", {
+ expect_error(
+ make_valid_parquet_version("0.3.14"),
+ '`version` must be one of'
+ )
+ expect_error(
+ make_valid_parquet_version(NULL),
+ '`version` must be one of'
Review Comment:
```suggestion
"`version` must be one of"
```
##########
r/tests/testthat/test-parquet.R:
##########
@@ -129,15 +129,51 @@ test_that("write_parquet() can truncate timestamps", {
expect_equal(as.data.frame(tab), as.data.frame(new))
})
-test_that("make_valid_version()", {
- expect_equal(make_valid_version("1.0"), ParquetVersionType$PARQUET_1_0)
- expect_equal(make_valid_version("2.0"), ParquetVersionType$PARQUET_2_0)
+test_that("make_valid_parquet_version()", {
+ expect_equal(
+ make_valid_parquet_version("1.0"),
+ ParquetVersionType$PARQUET_1_0
+ )
+ expect_deprecated(
+ expect_equal(
+ make_valid_parquet_version("2.0"),
+ ParquetVersionType$PARQUET_2_0
+ )
+ )
+ expect_equal(
+ make_valid_parquet_version("2.4"),
+ ParquetVersionType$PARQUET_2_4
+ )
+ expect_equal(
+ make_valid_parquet_version("2.6"),
+ ParquetVersionType$PARQUET_2_6
+ )
+ expect_equal(
+ make_valid_parquet_version("latest"),
+ ParquetVersionType$PARQUET_2_6
+ )
- expect_equal(make_valid_version(1), ParquetVersionType$PARQUET_1_0)
- expect_equal(make_valid_version(2), ParquetVersionType$PARQUET_2_0)
+ expect_equal(make_valid_parquet_version(1), ParquetVersionType$PARQUET_1_0)
+ expect_deprecated(
+ expect_equal(make_valid_parquet_version(2), ParquetVersionType$PARQUET_2_0)
+ )
+ expect_equal(make_valid_parquet_version(1.0), ParquetVersionType$PARQUET_1_0)
+ expect_equal(make_valid_parquet_version(2.4), ParquetVersionType$PARQUET_2_4)
+})
- expect_equal(make_valid_version(1.0), ParquetVersionType$PARQUET_1_0)
- expect_equal(make_valid_version(2.0), ParquetVersionType$PARQUET_2_0)
+test_that("make_valid_parquet_version() input validation", {
+ expect_error(
+ make_valid_parquet_version("0.3.14"),
+ '`version` must be one of'
Review Comment:
```suggestion
"`version` must be one of"
```
##########
r/tests/testthat/test-parquet.R:
##########
@@ -129,15 +129,51 @@ test_that("write_parquet() can truncate timestamps", {
expect_equal(as.data.frame(tab), as.data.frame(new))
})
-test_that("make_valid_version()", {
- expect_equal(make_valid_version("1.0"), ParquetVersionType$PARQUET_1_0)
- expect_equal(make_valid_version("2.0"), ParquetVersionType$PARQUET_2_0)
+test_that("make_valid_parquet_version()", {
+ expect_equal(
+ make_valid_parquet_version("1.0"),
+ ParquetVersionType$PARQUET_1_0
+ )
+ expect_deprecated(
+ expect_equal(
+ make_valid_parquet_version("2.0"),
+ ParquetVersionType$PARQUET_2_0
+ )
+ )
+ expect_equal(
+ make_valid_parquet_version("2.4"),
+ ParquetVersionType$PARQUET_2_4
+ )
+ expect_equal(
+ make_valid_parquet_version("2.6"),
+ ParquetVersionType$PARQUET_2_6
+ )
+ expect_equal(
+ make_valid_parquet_version("latest"),
+ ParquetVersionType$PARQUET_2_6
+ )
- expect_equal(make_valid_version(1), ParquetVersionType$PARQUET_1_0)
- expect_equal(make_valid_version(2), ParquetVersionType$PARQUET_2_0)
+ expect_equal(make_valid_parquet_version(1), ParquetVersionType$PARQUET_1_0)
+ expect_deprecated(
+ expect_equal(make_valid_parquet_version(2), ParquetVersionType$PARQUET_2_0)
+ )
+ expect_equal(make_valid_parquet_version(1.0), ParquetVersionType$PARQUET_1_0)
+ expect_equal(make_valid_parquet_version(2.4), ParquetVersionType$PARQUET_2_4)
+})
- expect_equal(make_valid_version(1.0), ParquetVersionType$PARQUET_1_0)
- expect_equal(make_valid_version(2.0), ParquetVersionType$PARQUET_2_0)
+test_that("make_valid_parquet_version() input validation", {
+ expect_error(
+ make_valid_parquet_version("0.3.14"),
+ '`version` must be one of'
+ )
+ expect_error(
+ make_valid_parquet_version(NULL),
+ '`version` must be one of'
+ )
+ expect_error(
+ make_valid_parquet_version(c("2", "4")),
+ '`version` must be one of'
Review Comment:
```suggestion
"`version` must be one of"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org