[GitHub] [druid] clintropolis commented on a change in pull request #10213: Avoid deletion of load/drop entry from CuratorLoadQueuePeon in case of load timeout

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #10213:
URL: https://github.com/apache/druid/pull/10213#discussion_r581022989



##########
File path: server/src/main/java/org/apache/druid/server/coordinator/CuratorLoadQueuePeon.java
##########
@@ -282,14 +297,14 @@ public void run()
           () -> {
             try {
               if (curator.checkExists().forPath(path) != null) {
-                failAssign(segmentHolder, new ISE("%s was never removed! Failing this operation!", path));
+                failAssign(segmentHolder, true, new ISE("%s was never removed! Failing this operation!", path));

Review comment:
       I think it would be worth clarifying this log message to indicate that for load operations, that while the coordinator has given up, the historical might still process and load the requested segments. Maybe something like "Load segments operation timed out, %s was never removed! Abandoning attempt, (but these segments might still be loaded)". I guess it would need to adjust message based on whether it was a load or drop.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org