[GitHub] [incubator-druid] leventov commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #8974: Fix double-checked locking in predicate suppliers in BoundDimFilter
URL: https://github.com/apache/incubator-druid/pull/8974#discussion_r352698531
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/filter/BoundDimFilter.java
 ##########
 @@ -361,107 +361,107 @@ public String toString()
     class BoundLongPredicateSupplier implements Supplier<DruidLongPredicate>
 
 Review comment:
   This class is actually a duplicate of `Suppliers.memoize()`. So code can be `return Suppliers.memoize(BoundDimFilter::createLongPredicate)`, assuming `updateSyncedDruidLongPredicate()` is renamed to `createLongPredicate()` and moved one level up.
   
   Same below.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org