You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2017/06/27 04:20:32 UTC

[GitHub] spark pull request #14431: [SPARK-16258][SparkR] Automatically append the gr...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14431#discussion_r124175513
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -1465,10 +1464,10 @@ setMethod("dapplyCollect",
     #'
     #' Result
     #' ---------
    -#' Model  (Intercept)  Sepal_Width  Petal_Length  Petal_Width
    -#' 1        0.699883    0.3303370    0.9455356    -0.1697527
    -#' 2        1.895540    0.3868576    0.9083370    -0.6792238
    -#' 3        2.351890    0.6548350    0.2375602     0.2521257
    +#' Model  Species     (Intercept)  Sepal_Width  Petal_Length  Petal_Width
    --- End diff --
    
    This is an external change. I think such an external change is not acceptable after we already introduce it. Right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org