You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/30 11:20:13 UTC
[GitHub] [shardingsphere] tuichenchuxin opened a new pull request, #22539: Make sys_data each table row saving a z-node.
tuichenchuxin opened a new pull request, #22539:
URL: https://github.com/apache/shardingsphere/pull/22539
For #22052.
Changes proposed in this pull request:
- Make sys_data each table row saving a z-node.
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22539: Make sys_data each table row saving a z-node.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22539:
URL: https://github.com/apache/shardingsphere/pull/22539#issuecomment-1332038151
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22539?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22539](https://codecov.io/gh/apache/shardingsphere/pull/22539?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f2527c) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ee7db7d4390824d81a1aac4035d2bddd42954eff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ee7db7d) will **decrease** coverage by `0.05%`.
> The diff coverage is `5.40%`.
```diff
@@ Coverage Diff @@
## master #22539 +/- ##
============================================
- Coverage 50.98% 50.93% -0.06%
- Complexity 2514 2515 +1
============================================
Files 4185 4189 +4
Lines 58237 58287 +50
Branches 9902 9913 +11
============================================
- Hits 29694 29688 -6
- Misses 26013 26067 +54
- Partials 2530 2532 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/infra/config/props/ConfigurationPropertyKey.java](https://codecov.io/gh/apache/shardingsphere/pull/22539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jb25maWcvcHJvcHMvQ29uZmlndXJhdGlvblByb3BlcnR5S2V5LmphdmE=) | `100.00% <ø> (ø)` | |
| [...ere/infra/metadata/data/ShardingSphereRowData.java](https://codecov.io/gh/apache/shardingsphere/pull/22539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhL1NoYXJkaW5nU3BoZXJlUm93RGF0YS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nfra/yaml/data/pojo/YamlShardingSphereRowData.java](https://codecov.io/gh/apache/shardingsphere/pull/22539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2RhdGEvcG9qby9ZYW1sU2hhcmRpbmdTcGhlcmVSb3dEYXRhLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ra/yaml/data/pojo/YamlShardingSphereTableData.java](https://codecov.io/gh/apache/shardingsphere/pull/22539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2RhdGEvcG9qby9ZYW1sU2hhcmRpbmdTcGhlcmVUYWJsZURhdGEuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...data/swapper/YamlShardingSphereRowDataSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/22539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2RhdGEvc3dhcHBlci9ZYW1sU2hhcmRpbmdTcGhlcmVSb3dEYXRhU3dhcHBlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ta/swapper/YamlShardingSphereTableDataSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/22539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2RhdGEvc3dhcHBlci9ZYW1sU2hhcmRpbmdTcGhlcmVUYWJsZURhdGFTd2FwcGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...he/shardingsphere/mode/manager/ContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/22539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvQ29udGV4dE1hbmFnZXIuamF2YQ==) | `54.20% <0.00%> (+0.36%)` | :arrow_up: |
| [...persist/data/ShardingSphereDataPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/22539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21ldGFkYXRhL3BlcnNpc3QvZGF0YS9TaGFyZGluZ1NwaGVyZURhdGFQZXJzaXN0U2VydmljZS5qYXZh) | `5.76% <0.00%> (-0.12%)` | :arrow_down: |
| [.../metadata/persist/node/ShardingSphereDataNode.java](https://codecov.io/gh/apache/shardingsphere/pull/22539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21ldGFkYXRhL3BlcnNpc3Qvbm9kZS9TaGFyZGluZ1NwaGVyZURhdGFOb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...egistry/data/ShardingSphereDataChangedWatcher.java](https://codecov.io/gh/apache/shardingsphere/pull/22539/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL2NsdXN0ZXIvY29vcmRpbmF0b3IvcmVnaXN0cnkvZGF0YS9TaGFyZGluZ1NwaGVyZURhdGFDaGFuZ2VkV2F0Y2hlci5qYXZh) | `3.63% <0.00%> (ø)` | |
| ... and [28 more](https://codecov.io/gh/apache/shardingsphere/pull/22539/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #22539: Make sys_data each table row saving a z-node.
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #22539:
URL: https://github.com/apache/shardingsphere/pull/22539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org