You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/15 22:16:51 UTC
[GitHub] [airflow] EliMor opened a new issue #18283: db+ string in result backend but not metadata secret
EliMor opened a new issue #18283:
URL: https://github.com/apache/airflow/issues/18283
### Official Helm Chart version
1.1.0 (latest released)
### Apache Airflow version
2.1.3 (latest released)
### Kubernetes Version
1.21
### Helm Chart configuration
data:
metadataSecretName: "airflow-metadata"
resultBackendSecretName: "airflow-result-backend"
### Docker Image customisations
_No response_
### What happened
If we only supply 1 secret with
```
connection: postgresql://airflow:password@postgres.rds:5432/airflow?sslmode=disable
```
To use for both metadata and resultBackendConnection then we end up with a connection error because
resultBackendConnection expects the string to be formatted like
```
connection: db+postgresql://airflow:password@postgres.rds:5432/airflow?sslmode=disable
```
from what i can tell
### What you expected to happen
I'd expect to be able to use the same secret for both using the same format if they are using the same connection.
### How to reproduce
Make a secret structured like above to look like the metadataConnection auto-generated secret.
use that same secret for the result backend.
deploy.
### Anything else
Occurs always.
To get around currently we make 2 secrets one with just the db+ prepended.
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #18283: db+ string in result backend but not metadata secret
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #18283:
URL: https://github.com/apache/airflow/issues/18283#issuecomment-920704362
Feel free @bigyan-kc. @EliMor - you can review the change :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #18283: db+ string in result backend but not metadata secret
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #18283:
URL: https://github.com/apache/airflow/issues/18283#issuecomment-920704362
Feel free1 @EliMor - you can review the change :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bigyan-kc commented on issue #18283: db+ string in result backend but not metadata secret
Posted by GitBox <gi...@apache.org>.
bigyan-kc commented on issue #18283:
URL: https://github.com/apache/airflow/issues/18283#issuecomment-921384894
@EliMor sure I will also add comment to the values file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vijaya-lakshmi-venkatraman commented on issue #18283: db+ string in result backend but not metadata secret
Posted by GitBox <gi...@apache.org>.
vijaya-lakshmi-venkatraman commented on issue #18283:
URL: https://github.com/apache/airflow/issues/18283#issuecomment-1021084544
Hello,
Is this still available?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] EliMor commented on issue #18283: db+ string in result backend but not metadata secret
Posted by GitBox <gi...@apache.org>.
EliMor commented on issue #18283:
URL: https://github.com/apache/airflow/issues/18283#issuecomment-921075269
Thank you @potiuk
I was wondering if we could also add a small comment to the values file to hint what the secret created should look like.
Somewhere around here; https://github.com/apache/airflow/blob/main/chart/values.yaml#L242
Could you add that as well @bigyan-kc please if @potiuk thinks its worth it?
Thank you again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] EliMor commented on issue #18283: db+ string in result backend but not metadata secret
Posted by GitBox <gi...@apache.org>.
EliMor commented on issue #18283:
URL: https://github.com/apache/airflow/issues/18283#issuecomment-920566866
I'd be happy to try to take this, but if @bigyan-kc would like to I don't want to stand in the way.
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bigyan-kc commented on issue #18283: db+ string in result backend but not metadata secret
Posted by GitBox <gi...@apache.org>.
bigyan-kc commented on issue #18283:
URL: https://github.com/apache/airflow/issues/18283#issuecomment-920545154
@potiuk Can I take this? I will submit PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #18283: db+ string in result backend but not metadata secret
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #18283:
URL: https://github.com/apache/airflow/issues/18283#issuecomment-920704362
Feel free1 @bigyan-ko. @EliMor - you can review the change :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #18283: db+ string in result backend but not metadata secret
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #18283:
URL: https://github.com/apache/airflow/issues/18283#issuecomment-920449973
I am not sure this is a helm-chart issue. It could probably be handled by the airflow itself - there are just few prefixes of the URL that could be shared with Airflow Metadata DB (postgres/sqlite/mysql variants) and it could be as easy of adding `db+` in front.
@EliMor - maybe you would like to make a PR in Airflow to implement it? Sounds like an easy thing for a small, nice contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #18283: db+ string in result backend but not metadata secret
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #18283:
URL: https://github.com/apache/airflow/issues/18283#issuecomment-920704362
Feel free @bigyan-ko. @EliMor - you can review the change :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vijaya-lakshmi-venkatraman commented on issue #18283: db+ string in result backend but not metadata secret
Posted by GitBox <gi...@apache.org>.
vijaya-lakshmi-venkatraman commented on issue #18283:
URL: https://github.com/apache/airflow/issues/18283#issuecomment-1021084544
Hello,
Is this still available?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org