[GitHub] [skywalking] bb7133 commented on a change in pull request #7691: tidb write by batch sql ,improve write speed.

[GitBox <gi...@apache.org>]

bb7133 commented on a change in pull request #7691:
URL: https://github.com/apache/skywalking/pull/7691#discussion_r709149524



##########
File path: oap-server/server-starter/src/main/resources/application.yml
##########
@@ -170,9 +172,11 @@ storage:
     metadataQueryMaxSize: ${SW_STORAGE_MYSQL_QUERY_MAX_SIZE:5000}
     maxSizeOfArrayColumn: ${SW_STORAGE_MAX_SIZE_OF_ARRAY_COLUMN:20}
     numOfSearchableValuesPerTag: ${SW_STORAGE_NUM_OF_SEARCHABLE_VALUES_PER_TAG:2}
+    maxSizeOfBatchSql: ${SW_STORAGE_MAX_SIZE_OF_BATCH_SQL:2000}
+    asyncBatchPersistentPoolSize: ${SW_STORAGE_ASYNC_BATCH_PERSISTENT_POOL_SIZE:4}
   tidb:
     properties:
-      jdbcUrl: ${SW_JDBC_URL:"jdbc:mysql://localhost:4000/tidbswtest"}
+      jdbcUrl: ${SW_JDBC_URL:"jdbc:mysql://localhost:4000/tidbswtest?rewriteBatchedStatements=true"}

Review comment:
       > Then, whether we should add them to MySQL too at least
   
   It is applicable to both MySQL and TiDB(and other databases, of course), you can also check it in the ['best practice' part](https://docs.pingcap.com/tidb/stable/java-app-best-practices#use-batch-api) of TiDB website.
   
   I would recommend setting it for MySQL, too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org