[jira] [Commented] (HBASE-13491) Issue in FuzzyRowFilter#getNextForFuzzyRule

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-13491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499579#comment-14499579 ] 

Hadoop QA commented on HBASE-13491:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12726095/HBASE-13491.patch
  against master branch at commit 7fb6055ed7304b05a383a730b64e55e41772bcf8.
  ATTACHMENT ID: 12726095

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13733//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13733//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13733//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13733//console

This message is automatically generated.

> Issue in FuzzyRowFilter#getNextForFuzzyRule
> -------------------------------------------
>
>                 Key: HBASE-13491
>                 URL: https://issues.apache.org/jira/browse/HBASE-13491
>             Project: HBase
>          Issue Type: Bug
>          Components: Filters
>    Affects Versions: 1.0.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0, 1.0.1, 1.1.0, 1.2.0
>
>         Attachments: HBASE-13491.patch
>
>
> {code}
> for (int i = 0; i < result.length; i++) {
>       if (i >= fuzzyKeyMeta.length || fuzzyKeyMeta[i] == 1) {
>         result[i] = row[offset + i];
>         if (!order.isMax(row[i])) {
>           // this is "non-fixed" position and is not at max value, hence we can increase it
>           toInc = i;
>         }
>       }
> {code}
> See we take row bytes with out considering the row offset.  The test cases are passing as we pass 0 offset row bytes. Change in the test will reveal the bug.
> Came across this when I was working on HBASE-11425



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)