You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/03/12 18:51:45 UTC
[GitHub] [gobblin] milimetric opened a new pull request #3244: [GOBBLIN-1409] Expose record timestamp in kafka-1 client
milimetric opened a new pull request #3244:
URL: https://github.com/apache/gobblin/pull/3244
Dear Gobblin maintainers,
This is my first PR, please do point out any mistakes or omissions.
### JIRA
[GOBBLIN-1409](https://issues.apache.org/jira/browse/GOBBLIN-1409)
### Description
When consuming from Kafka, we need the kafka timestamp and timestamp type. This change implements the necessary methods.
### Tests
- The existing test was updated to check the new methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] milimetric commented on pull request #3244: [GOBBLIN-1409] Expose record timestamp in kafka-1 client
Posted by GitBox <gi...@apache.org>.
milimetric commented on pull request #3244:
URL: https://github.com/apache/gobblin/pull/3244#issuecomment-797680514
Apologies for the initial hiccup, I think I straightened it out. cc @ZihanLi58
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] shirshanka commented on pull request #3244: [GOBBLIN-1409] Expose record timestamp in kafka-1 client
Posted by GitBox <gi...@apache.org>.
shirshanka commented on pull request #3244:
URL: https://github.com/apache/gobblin/pull/3244#issuecomment-817067629
@milimetric : thanks for the contribution and sorry for the delay in merging this in!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] asfgit closed pull request #3244: [GOBBLIN-1409] Expose record timestamp in kafka-1 client
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3244:
URL: https://github.com/apache/gobblin/pull/3244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] milimetric commented on pull request #3244: [GOBBLIN-1409] Expose record timestamp in kafka-1 client
Posted by GitBox <gi...@apache.org>.
milimetric commented on pull request #3244:
URL: https://github.com/apache/gobblin/pull/3244#issuecomment-817232261
My pleasure! Thank you for the guidance.
On Fri, Apr 9, 2021 at 22:58 Shirshanka Das ***@***.***>
wrote:
> @milimetric <https://github.com/milimetric> : thanks for the contribution
> and sorry for the delay in merging this in!
>
> —
> You are receiving this because you were mentioned.
>
>
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/gobblin/pull/3244#issuecomment-817067629>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAH5UUBDXVH3DDSOQMBD2PLTH65FDANCNFSM4ZCYONKA>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] milimetric commented on pull request #3244: [GOBBLIN-1409] Expose record timestamp in kafka-1 client
Posted by GitBox <gi...@apache.org>.
milimetric commented on pull request #3244:
URL: https://github.com/apache/gobblin/pull/3244#issuecomment-815946989
Just a gentle bump here, we're wondering about rough timelines of PRs as we strategize about our deployment of gobblin. Any info is appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-io commented on pull request #3244: [GOBBLIN-1409] Expose record timestamp in kafka-1 client
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #3244:
URL: https://github.com/apache/gobblin/pull/3244#issuecomment-797695770
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3244?src=pr&el=h1) Report
> Merging [#3244](https://codecov.io/gh/apache/gobblin/pull/3244?src=pr&el=desc) (9f53f71) into [master](https://codecov.io/gh/apache/gobblin/commit/1cbe3d0aacf47edb78bf50986d70047e49f72798?el=desc) (1cbe3d0) will **decrease** coverage by `37.37%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/gobblin/pull/3244?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3244 +/- ##
============================================
- Coverage 46.40% 9.03% -37.38%
+ Complexity 9940 1737 -8203
============================================
Files 2030 2030
Lines 78783 78786 +3
Branches 8765 8766 +1
============================================
- Hits 36561 7117 -29444
- Misses 38815 70973 +32158
+ Partials 3407 696 -2711
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3244?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/gobblin/kafka/client/Kafka1ConsumerClient.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9rYWZrYS9jbGllbnQvS2Fma2ExQ29uc3VtZXJDbGllbnQuamF2YQ==) | `0.00% <0.00%> (-23.72%)` | `0.00 <0.00> (-6.00)` | |
| [...c/main/java/org/apache/gobblin/util/FileUtils.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZVV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...n/java/org/apache/gobblin/fork/CopyableSchema.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZvcmsvQ29weWFibGVTY2hlbWEuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...java/org/apache/gobblin/stream/ControlMessage.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc3RyZWFtL0NvbnRyb2xNZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...va/org/apache/gobblin/dataset/DatasetResolver.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9EYXRhc2V0UmVzb2x2ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...va/org/apache/gobblin/converter/EmptyIterable.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9FbXB0eUl0ZXJhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...org/apache/gobblin/ack/BasicAckableForTesting.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYWNrL0Jhc2ljQWNrYWJsZUZvclRlc3RpbmcuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...n/java/org/apache/gobblin/salesforce/SfConfig.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2ZDb25maWcuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../org/apache/gobblin/yarn/HelixMessageSubTypes.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vSGVsaXhNZXNzYWdlU3ViVHlwZXMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...va/org/apache/gobblin/cluster/SingleHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlSGVsaXhUYXNrLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [1074 more](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3244?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3244?src=pr&el=footer). Last update [1cbe3d0...9f53f71](https://codecov.io/gh/apache/gobblin/pull/3244?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org