You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/01 02:23:09 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27740: ForeachBatch java example fix

HyukjinKwon commented on a change in pull request #27740: ForeachBatch java example fix
URL: https://github.com/apache/spark/pull/27740#discussion_r386070667
 
 

 ##########
 File path: docs/structured-streaming-programming-guide.md
 ##########
 @@ -2202,7 +2202,7 @@ streamingDatasetOfString.writeStream.foreach(
 In Java, you have to extend the class `ForeachWriter` ([docs](api/java/org/apache/spark/sql/ForeachWriter.html)).
 {% highlight java %}
 streamingDatasetOfString.writeStream().foreach(
-  new ForeachWriter[String] {
+  new ForeachWriter<String>() {
 
 Review comment:
   This seems already fixed at https://github.com/apache/spark/commit/9a2cec9b1ee3ba095461d9c07c9932107228d42e . Can you remove this in your PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org