[GitHub] [cordova-android] erisu commented on issue #896: feat: add kotlin support

[GitBox <gi...@apache.org>]

erisu commented on issue #896: feat: add kotlin support
URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574994317
 
 
   @timbru31
   
   I went ahead and created a new Kotlin support PR so we can quickly apply all the changes and improvements to get Kotlin prepared and released hopefully in the next day or 2.
   
   Per your change request in the previous PR, I have:
   
   * Updated Kotlin to the latest version
   
   * Replaced `mavenCentral` with `jcenter` in the `test/app/build.gradle`
     
   **NOTICE**: 
   This change is not applied to the actual `build.gradle` that is used when building a Cordova project. The actual file, `bin/templates/project/app/build.gradle`, still uses in the following order:
   
       mavenCentral -> google -> jcenter
   
   If these are to be updated, it should be taken care of in a separate PR
   
   * Per your comment about `kotlin:kotlin-stdlib-jdk7` I believe it is best to keep it as `kotlin:kotlin-stdlib-jdk7`. A newly created Android project with the official Android Studio uses `kotlin:kotlin-stdlib-jdk7`. Probably best to not do something different.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org