You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by GitBox <gi...@apache.org> on 2019/09/24 15:43:00 UTC

[GitHub] [metron] merrimanr opened a new pull request #1519: METRON-2265: Update Kerberos settings

merrimanr opened a new pull request #1519: METRON-2265: Update Kerberos settings
URL: https://github.com/apache/metron/pull/1519
 
 
   ## Contributor Comments
   This PR includes code and documentation changes for enabling Kerberos in HDP 3.1.   The primary changes needed were minor Maven changes and making the Metron JAAS setting available to Kafka through `KAFKA_OPTS`. 
   
   ### Changes Included
   
   - Changes to KDC setup documentation for Centos7
   - Changes to Kerberos setup documentation for HDP 3.1
   - Minor Mpack change for looking up a host name
   - Addition of a `CLIENT_JAAS_ARG` property to `/etc/default/metron`.  This is needed separately from `METRON_JVMFLAGS `
   -  Updated the Kafka `security.protocol` setting to `SASL_PLAINTEXT`
   - Maven changes to handle classpath errors that result from the extra jars added by Storm when Kerberos is enabled.  The extra jars are located in `/usr/hdp/current/storm-supervisor/external/storm-autocreds/*`.
   - Replaced a call to `org.apache.commons.math.util.MathUtils` with a standard Java implementation.  This dependency was being pulled in transitively.
   - Fixed a bug in `metron-data-management` that resulted from `com.google.thirdparty` not being shaded.
   
   ### Testing
   I attempted to test the various components (Storm, Kafka, HBase, Hadoop, etc) to verify they still work after Kerberos is enabled.  The instructions in `Kerberos-manual-setup.md` should now be correct.  Also there should not be any additional steps needed to enabled the sensor stubs other than a simple restart.  I tested the following after spinning up full dev:
   
   - Verified data is flowing through to ES and HDFS and the Alerts UI works.
   - Verified the various Profiler README examples work
   - Verified the `flatfile_loader.sh` script works as expected
   - Verified Stellar works with Kafka (added docs for this)
   
   I believe this should cover almost all of the components.  There were not any specific Solr changes required (was done in the [Solr upgrade PR](https://issues.apache.org/jira/browse/METRON-2225)) but we might want to test this too.
   
   ## Pull Request Checklist
   
   Thank you for submitting a contribution to Apache Metron.  
   Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
   Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
   
   
   In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
   - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   
   ### For code changes:
   - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
   - [x] Have you included steps or a guide to how the change may be verified and tested manually?
   - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
     ```
     mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
     ```
   
   - [x] Have you written or updated unit tests and or integration tests to verify your changes?
   - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
   
   ### For documentation related changes:
   - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
   
     ```
     cd site-book
     mvn site
     ```
   
   - [x] Have you ensured that any documentation diagrams have been updated, along with their source files, using [draw.io](https://www.draw.io/)? See [Metron Development Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines) for instructions.
   
   #### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services