You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@quickstep.apache.org by zuyu <gi...@git.apache.org> on 2017/04/01 03:33:32 UTC

[GitHub] incubator-quickstep pull request #219: QUICKSTEP-83 Measure memory consumpti...

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/219#discussion_r109276326
  
    --- Diff: storage/PartitionedHashTablePool.hpp ---
    @@ -113,6 +113,19 @@ class PartitionedHashTablePool {
         return num_partitions_;
       }
     
    +  /**
    +   * @brief Get the total memory consumed by the hash tables in this pool.
    +   **/
    +  std::size_t getMemoryConsumptionPoolBytes() {
    --- End diff --
    
    Please add `const` here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---