[GitHub] [incubator-mxnet] ptrendx edited a comment on issue #15285: Graph dumper

[GitBox <gi...@apache.org>]

ptrendx edited a comment on issue #15285: Graph dumper
URL: https://github.com/apache/incubator-mxnet/pull/15285#issuecomment-509835138
 
 
   > For feedback to be useful it has also to be concrete, in this case I don't see the feedback to my code change proposal is concrete enough for me to take actions. Could you post an example of how would you propose to use indexed graph to do the same effect? Maybe that would help keep the conversation focused. It's also a debugging feature, so I don't feel specially passionate about defending my design decisions here.
   
   Sure, so I would do this serialization more or less like this pseudo-code:
   ```
   // g - the nnvm::Graph that is being serialized
   idx = g.indexed_graph();
   for (i = 0; i < idx.num_nodes(); ++i) {
   const auto& node = g[i];
   for (const auto& input : node.inputs()) {
   // input.source is the src node
   // node is the dst node
   dump "src -> dst" to dot
   }
   }
   for (const auto& output : idx.outputs) {
   // output.source is the src node
   // "Output N" is the dst node
   dump "src->dst" to dot
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services