You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/09/25 03:59:17 UTC
[GitHub] codecov-io commented on issue #450: SCB-938 Should check self
presevation max ttl
codecov-io commented on issue #450: SCB-938 Should check self presevation max ttl
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/450#issuecomment-424199820
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450?src=pr&el=h1) Report
> Merging [#450](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/95013d48d6c3db50c10f575a29d0b773fb9c4128?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #450 +/- ##
==========================================
- Coverage 59.77% 59.76% -0.01%
==========================================
Files 149 149
Lines 13174 13176 +2
==========================================
Hits 7875 7875
Misses 4727 4727
- Partials 572 574 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/core/backend/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9jb21tb24uZ28=) | `100% <ø> (ø)` | :arrow_up: |
| [server/core/backend/defer\_instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9kZWZlcl9pbnN0YW5jZS5nbw==) | `86.02% <88.88%> (+0.3%)` | :arrow_up: |
| [server/plugin/infra/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL3RyYWNpbmcuZ28=) | `72.72% <0%> (-9.1%)` | :arrow_down: |
| [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450?src=pr&el=footer). Last update [95013d4...65d86e3](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/450?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services