You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/05/03 17:17:06 UTC

[GitHub] [incubator-echarts] plainheart opened a new pull request #12558: fix(bmap): bmap event `moveend` is always triggered when dragging or zoomend.

plainheart opened a new pull request #12558:
URL: https://github.com/apache/incubator-echarts/pull/12558


   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Fix bugs:
    - 1. bmap event `moveend` is always triggered when dragging
    - 2. bmap event `moveend` is triggered when zoomend
   
   ## Details
   
   ### Before: What was the problem?
   
   When you added an event listener `moveend` on bmap, and then try to drag or zoom the map, the `moveend` event will be always triggered unexpectedly.
   
   **Code to Reproduce** 
   ```js
   var bmap = myChart.getModel().getComponent('bmap').getBMap();
    bmap.addEventListener('moveend', function(e) {
       console.log(e.type);
    });              
   ```
   
   **Unexpected Result**
   
   ![image](https://user-images.githubusercontent.com/26999792/80919991-8cd04f80-8d9f-11ea-874b-8f44f548596e.png)
   
   
   
   ### After: How is it fixed in this PR?
   
   In the file `BMapCoordSys.js`, before chart layout and render, don't set center and zoom of bmap if both center and zoom are not changed in `BMapCoordSys`.
   
   **Code to Fix**
   ![image](https://user-images.githubusercontent.com/26999792/80920163-94dcbf00-8da0-11ea-864a-1a2841d010d7.png)
   
   **Expected Result**
   
   ![image](https://user-images.githubusercontent.com/26999792/80920316-8e027c00-8da1-11ea-8c58-f8c96907cd74.png)
   
   ## Usage
   
   ### Related test cases or examples to use the new APIs
   
   Refer to `test/bmap2.html`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12558: fix(bmap): bmap event `moveend` is always triggered when dragging or zoomend.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12558:
URL: https://github.com/apache/incubator-echarts/pull/12558#issuecomment-623146951


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12558: fix(bmap): bmap event `moveend` is always triggered when dragging or zoomend.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12558:
URL: https://github.com/apache/incubator-echarts/pull/12558#issuecomment-668398141


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] pissang merged pull request #12558: fix(bmap): bmap event `moveend` is always triggered when dragging or zoomend.

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #12558:
URL: https://github.com/apache/incubator-echarts/pull/12558


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org