You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/04/06 21:39:35 UTC
[kudu-CR] [mini-cluster] allow more time for masters start up
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6571
Change subject: [mini-cluster] allow more time for masters start up
......................................................................
[mini-cluster] allow more time for masters start up
In case of sanitizer-enabled builds running on slow VMs it might take
more than 5 seconds to start Kudu master.
This patch is to fix master_cert_authority-itest flakiness.
Change-Id: Ic3dd9aa9c1620d69b6ae4a877912e5d63e4d5a85
---
M src/kudu/integration-tests/mini_cluster.cc
1 file changed, 10 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/6571/1
--
To view, visit http://gerrit.cloudera.org:8080/6571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3dd9aa9c1620d69b6ae4a877912e5d63e4d5a85
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [mini-cluster] allow more time for masters start up
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [mini-cluster] allow more time for masters start up
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3dd9aa9c1620d69b6ae4a877912e5d63e4d5a85
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [mini-cluster] allow more time for masters start up
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6571
to look at the new patch set (#2).
Change subject: [mini-cluster] allow more time for masters start up
......................................................................
[mini-cluster] allow more time for masters start up
In case of sanitizer-enabled builds running on slow VMs it might take
more than 5 seconds to start Kudu master.
This patch is to fix master_cert_authority-itest flakiness.
Change-Id: Ic3dd9aa9c1620d69b6ae4a877912e5d63e4d5a85
---
M src/kudu/integration-tests/mini_cluster.cc
M src/kudu/integration-tests/mini_cluster.h
2 files changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/6571/2
--
To view, visit http://gerrit.cloudera.org:8080/6571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic3dd9aa9c1620d69b6ae4a877912e5d63e4d5a85
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [mini-cluster] allow more time for masters start up
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [mini-cluster] allow more time for masters start up
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6571/1/src/kudu/integration-tests/mini_cluster.cc
File src/kudu/integration-tests/mini_cluster.cc:
Line 302: static const MonoDelta kDeadlineDelta =
Maybe define this alongside kRegistrationWaitTimeSeconds?
Also, why not a 30s timeout in the non-sanitizer case? A cluster can be under excessive load for other reasons.
--
To view, visit http://gerrit.cloudera.org:8080/6571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3dd9aa9c1620d69b6ae4a877912e5d63e4d5a85
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [mini-cluster] allow more time for masters start up
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [mini-cluster] allow more time for masters start up
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6571/1/src/kudu/integration-tests/mini_cluster.cc
File src/kudu/integration-tests/mini_cluster.cc:
Line 302: static const MonoDelta kDeadlineDelta =
> Maybe define this alongside kRegistrationWaitTimeSeconds?
Good ideas!
--
To view, visit http://gerrit.cloudera.org:8080/6571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3dd9aa9c1620d69b6ae4a877912e5d63e4d5a85
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [mini-cluster] allow more time for masters start up
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [mini-cluster] allow more time for masters start up
......................................................................
[mini-cluster] allow more time for masters start up
In case of sanitizer-enabled builds running on slow VMs it might take
more than 5 seconds to start Kudu master.
This patch is to fix master_cert_authority-itest flakiness.
Change-Id: Ic3dd9aa9c1620d69b6ae4a877912e5d63e4d5a85
Reviewed-on: http://gerrit.cloudera.org:8080/6571
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/mini_cluster.cc
M src/kudu/integration-tests/mini_cluster.h
2 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3dd9aa9c1620d69b6ae4a877912e5d63e4d5a85
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>