You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/29 11:04:49 UTC
[GitHub] [arrow] mapleFU opened a new pull request, #15108: ARROW-17823: [C++] [Parquet] Prefer std::make_shared/std::make_unique over constructor with new in Parquet
mapleFU opened a new pull request, #15108:
URL: https://github.com/apache/arrow/pull/15108
This patch reuse the arrow issue https://issues.apache.org/jira/browse/ARROW-17823 .
Advantage: readabilty, exception safety and efficiency(only for shared_ptr).
Cases that don't apply: When calling a private/protected constructor within class member function, make_shared/unique can't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 merged pull request #15108: ARROW-17823: [C++] [Parquet] Prefer std::make_shared/std::make_unique over constructor with new in Parquet
Posted by GitBox <gi...@apache.org>.
wjones127 merged PR #15108:
URL: https://github.com/apache/arrow/pull/15108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #15108: ARROW-17823: [C++] [Parquet] Prefer std::make_shared/std::make_unique over constructor with new in Parquet
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #15108:
URL: https://github.com/apache/arrow/pull/15108#issuecomment-1368096400
Benchmark runs are scheduled for baseline = d00f016315408d653b2a46d3fd8922616264ced4 and contender = 237bc304f91b5ce5e231d8ad12109fe281aeb1ad. 237bc304f91b5ce5e231d8ad12109fe281aeb1ad is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6bacc697b792444495eaf0b54d277287...1456e8e78c71420e9bbe6990df6efb07/)
[Finished :arrow_down:10.24% :arrow_up:6.74%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/54b9851c02e1451e806ab90d10ff3e2b...e7d472e1163d4d1a93ebea222f06460e/)
[Finished :arrow_down:6.12% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b120607b37564d7c948ccbb79e077801...458b2da22df74590bde8e67dcc041a3e/)
[Finished :arrow_down:0.72% :arrow_up:0.65%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8b79fe59e6f5417fa8e51df5363f52d6...fdb69f98ce944dd299f4627222e2e9b6/)
Buildkite builds:
[Finished] [`237bc304` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2084)
[Finished] [`237bc304` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2106)
[Finished] [`237bc304` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2078)
[Finished] [`237bc304` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2098)
[Finished] [`d00f0163` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2083)
[Finished] [`d00f0163` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2105)
[Finished] [`d00f0163` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2077)
[Finished] [`d00f0163` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2097)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #15108: ARROW-17823: [C++] [Parquet] Prefer std::make_shared/std::make_unique over constructor with new in Parquet
Posted by GitBox <gi...@apache.org>.
mapleFU commented on PR #15108:
URL: https://github.com/apache/arrow/pull/15108#issuecomment-1367644260
Nice catch! Too much code here and I miss `parquet/arrow` part. PTAL again @wjones127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #15108: ARROW-17823: [C++] [Parquet] Prefer std::make_shared/std::make_unique over constructor with new in Parquet
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15108:
URL: https://github.com/apache/arrow/pull/15108#issuecomment-1367241896
https://issues.apache.org/jira/browse/ARROW-17823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on pull request #15108: ARROW-17823: [C++] [Parquet] Prefer std::make_shared/std::make_unique over constructor with new in Parquet
Posted by GitBox <gi...@apache.org>.
wjones127 commented on PR #15108:
URL: https://github.com/apache/arrow/pull/15108#issuecomment-1368004384
Thanks @mapleFU!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #15108: ARROW-17823: [C++] [Parquet] Prefer std::make_shared/std::make_unique over constructor with new in Parquet
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #15108:
URL: https://github.com/apache/arrow/pull/15108#issuecomment-1368096438
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/54b9851c02e1451e806ab90d10ff3e2b...e7d472e1163d4d1a93ebea222f06460e/)
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b120607b37564d7c948ccbb79e077801...458b2da22df74590bde8e67dcc041a3e/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org