You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/13 15:55:30 UTC
[GitHub] [iceberg] dimas-b commented on a diff in pull request #5221: Prevent usage of @Test(expected = ...) and change existing tests
dimas-b commented on code in PR #5221:
URL: https://github.com/apache/iceberg/pull/5221#discussion_r920248408
##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -410,6 +410,11 @@
<property name="format" value="(void setUp\(\))|(void setup\(\))|(void setupStatic\(\))|(void setUpStatic\(\))|(void beforeTest\(\))|(void teardown\(\))|(void tearDown\(\))|(void beforeStatic\(\))|(void afterStatic\(\))"/>
<property name="message" value="Test setup/teardown methods are called before(), beforeClass(), after(), afterClass(), but not setUp, teardown, etc."/>
</module>
+ <module name="RegexpSinglelineJava">
+ <property name="ignoreComments" value="true"/>
+ <property name="format" value="@Test\(.*expected.*\)"/>
+ <property name="message" value="Prefer using Assertions.assertThatThrownBy(...).isInstanceOf(...) instead."/>
Review Comment:
From my POV, `Assertions` statements pretty intuitive to read and interpret and in most cases result is very few lines of code. +1 to promoting them.
##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -410,6 +410,11 @@
<property name="format" value="(void setUp\(\))|(void setup\(\))|(void setupStatic\(\))|(void setUpStatic\(\))|(void beforeTest\(\))|(void teardown\(\))|(void tearDown\(\))|(void beforeStatic\(\))|(void afterStatic\(\))"/>
<property name="message" value="Test setup/teardown methods are called before(), beforeClass(), after(), afterClass(), but not setUp, teardown, etc."/>
</module>
+ <module name="RegexpSinglelineJava">
+ <property name="ignoreComments" value="true"/>
+ <property name="format" value="@Test\(.*expected.*\)"/>
+ <property name="message" value="Prefer using Assertions.assertThatThrownBy(...).isInstanceOf(...) instead."/>
Review Comment:
From my POV, `Assertions` statements are pretty intuitive to read and interpret and in most cases result is very few lines of code. +1 to promoting them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org