[GitHub] [trafficcontrol] mitchell852 opened a new pull request #4905: Fixes the inability to clone ds assignments across servers when 1+ ds is assigned a topology

[GitBox <gi...@apache.org>]

mitchell852 opened a new pull request #4905:
URL: https://github.com/apache/trafficcontrol/pull/4905


   ## What does this PR (Pull Request) do?
   With the introduction of topologies, it no longer makes sense to assign caches _directly_ to a delivery service if that ds utilizes a topology. Therefore, a constraint was added to the following api in #4702 to prevent delivery services from being assigned directly to a server if that delivery service utilizes a topology:
   
   `POST api/version/servers/{server-id}/deliveryservices`
   
   However, a common practice when provisioning new caches is to clone the ds assignments from an existing cache to the newly provisioned cache using the aforementioned endpoint. However, due to the new constraint added in #4702, this activity will inevitably fail as more delivery services start to use topologies but were never unassigned from the servers in which they were previously assigned. Confused yet? 
   
   Anyhow, removing this constraint will ease the transition from delivery services that utilize a topology and other delivery services that choose to assign servers directly. 
   
   - [x] This PR is not related to any Issue 
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   - Run the API tests and/or
   - POST api/3.x/servers/20/deliveryservices?replace=true
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR does NOT include documentation
   - [x] This PR does NOT include an update to CHANGELOG.md as the bug was introduced between releases
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 merged pull request #4905: Fixes the inability to clone ds assignments across servers when 1+ ds is assigned a topology

[GitBox <gi...@apache.org>]

ocket8888 merged pull request #4905:
URL: https://github.com/apache/trafficcontrol/pull/4905


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org