You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by se...@apache.org on 2015/08/14 21:42:26 UTC
svn commit: r1695974 - in /directory/apacheds/trunk/core-integ/src:
checkstyle/ checkstyle/suppressions.xml
main/java/org/apache/directory/server/core/integ/IntegrationUtils.java
Author: seelmann
Date: Fri Aug 14 19:42:26 2015
New Revision: 1695974
URL: http://svn.apache.org/r1695974
Log:
Fix checkstyle issues
Added:
directory/apacheds/trunk/core-integ/src/checkstyle/
directory/apacheds/trunk/core-integ/src/checkstyle/suppressions.xml (with props)
Modified:
directory/apacheds/trunk/core-integ/src/main/java/org/apache/directory/server/core/integ/IntegrationUtils.java
Added: directory/apacheds/trunk/core-integ/src/checkstyle/suppressions.xml
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/checkstyle/suppressions.xml?rev=1695974&view=auto
==============================================================================
--- directory/apacheds/trunk/core-integ/src/checkstyle/suppressions.xml (added)
+++ directory/apacheds/trunk/core-integ/src/checkstyle/suppressions.xml Fri Aug 14 19:42:26 2015
@@ -0,0 +1,29 @@
+<?xml version="1.0"?>
+
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+<!DOCTYPE suppressions PUBLIC
+ "-//Puppy Crawl//DTD Suppressions 1.1//EN"
+ "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
+
+<suppressions>
+ <!-- Large files -->
+ <suppress files="org.apache.directory.server.core.integ.IntegrationUtils" checks="HideUtilityClassConstructor"/>
+</suppressions>
Propchange: directory/apacheds/trunk/core-integ/src/checkstyle/suppressions.xml
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: directory/apacheds/trunk/core-integ/src/checkstyle/suppressions.xml
------------------------------------------------------------------------------
svn:mime-type = text/xml
Modified: directory/apacheds/trunk/core-integ/src/main/java/org/apache/directory/server/core/integ/IntegrationUtils.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-integ/src/main/java/org/apache/directory/server/core/integ/IntegrationUtils.java?rev=1695974&r1=1695973&r2=1695974&view=diff
==============================================================================
--- directory/apacheds/trunk/core-integ/src/main/java/org/apache/directory/server/core/integ/IntegrationUtils.java (original)
+++ directory/apacheds/trunk/core-integ/src/main/java/org/apache/directory/server/core/integ/IntegrationUtils.java Fri Aug 14 19:42:26 2015
@@ -68,7 +68,7 @@ public class IntegrationUtils
/** The class logger */
private static final Logger LOG = LoggerFactory.getLogger( IntegrationUtils.class );
- private static final List<LdapConnection> openConnections = new ArrayList<LdapConnection>();
+ private static final List<LdapConnection> OPEN_CONNECTIONS = new ArrayList<LdapConnection>();
/**
@@ -427,7 +427,7 @@ public class IntegrationUtils
LdapConnection connection = new LdapNetworkConnection( host, port );
connection.bind( dn, password );
- openConnections.add( connection );
+ OPEN_CONNECTIONS.add( connection );
return connection;
}
@@ -459,7 +459,7 @@ public class IntegrationUtils
LdapConnection connection = new LdapNetworkConnection( host, port );
connection.bind();
- openConnections.add( connection );
+ OPEN_CONNECTIONS.add( connection );
return connection;
}
@@ -479,7 +479,7 @@ public class IntegrationUtils
connection.setTimeOut( 0 );
connection.bind( ServerDNConstants.ADMIN_SYSTEM_DN, "secret" );
- openConnections.add( connection );
+ OPEN_CONNECTIONS.add( connection );
return connection;
}
@@ -505,7 +505,7 @@ public class IntegrationUtils
public static void closeConnections()
{
- for ( LdapConnection con : openConnections )
+ for ( LdapConnection con : OPEN_CONNECTIONS )
{
if ( con == null )
{
@@ -526,6 +526,6 @@ public class IntegrationUtils
}
}
- openConnections.clear();
+ OPEN_CONNECTIONS.clear();
}
}