You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "AndreyCurious (via GitHub)" <gi...@apache.org> on 2026/10/13 09:00:47 UTC
[PR] kie-issues#2414: [BPMN Editor] Update message refs on boundary events when renaming/deleting a Message [incubator-kie-tools]
AndreyCurious opened a new pull request, #4042:
URL: https://github.com/apache/incubator-kie-tools/pull/4042
Fixes apache/incubator-kie-issues#2414
## What
When a Message is renamed or deleted, the editor updates / clears the message reference (`drools:msgref`, `messageRef`) on message events. The visited event types listed `endEvent`, `intermediateThrowEvent`, `startEvent` and `intermediateCatchEvent` but omitted `boundaryEvent`.
As a result a boundary message event kept a stale `drools:msgref` after rename, or a dangling `messageRef` to the removed root `message` after delete — the latter producing a file that fails to parse on reopen.
## Change
Add `boundaryEvent` to that condition in `renameMessage.ts` and `deleteMessage.ts`, so boundary message events are handled like the other message events.
## How to verify
1. Create a process with a Message and a boundary message event referencing it.
2. Rename the message → the boundary event now gets the updated `drools:msgref`.
3. Delete the message → the boundary event message refs are cleared; the file still parses on reopen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2414: [BPMN Editor] Update event refs on boundary events when renaming/deleting Messages, Errors, Escalations and Signals [incubator-kie-tools]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #4042:
URL: https://github.com/apache/incubator-kie-tools/pull/4042#discussion_r4261889406
##########
packages/bpmn-editor/src/mutations/renameMessage.ts:
##########
@@ -65,7 +65,8 @@ export function renameMessage({
array[index].__$$element === "endEvent" ||
array[index].__$$element === "intermediateThrowEvent" ||
array[index].__$$element === "startEvent" ||
- array[index].__$$element === "intermediateCatchEvent"
+ array[index].__$$element === "intermediateCatchEvent" ||
+ array[index].__$$element === "boundaryEvent"
) {
Review Comment:
The same “supported event element types” condition appears duplicated across multiple mutation files, and this PR demonstrates it’s easy to miss one (e.g., `boundaryEvent`). To avoid future omissions and reduce repetition, consider centralizing these element-name checks into a shared helper/constant (e.g., a `Set`/array + `includes` / `has`) reused by all rename/delete mutations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2414: [BPMN Editor] Update event refs on boundary events when renaming/deleting Messages, Errors, Escalations and Signals [incubator-kie-tools]
Posted by "jomarko (via GitHub)" <gi...@apache.org>.
jomarko merged PR #4042:
URL: https://github.com/apache/incubator-kie-tools/pull/4042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org