[GitHub] [hive] pgaref edited a comment on pull request #1207: HIVE-23483: Remove DynamicSerDe

[GitBox <gi...@apache.org>]

pgaref edited a comment on pull request #1207:
URL: https://github.com/apache/hive/pull/1207#issuecomment-656152607


   > I've seen some additional usage, however I'm not sure how these are utilized, thus I left it in so far:
   > 
   > ```
   > ql/src/java/org/apache/hadoop/hive/ql/io/HiveBinaryOutputFormat.java:76:          // DynamicSerDe always writes out BytesWritable
   > serde/src/java/org/apache/hadoop/hive/serde2/thrift/TBinarySortableProtocol.java:150:      // If the struct is null and level > 1, DynamicSerDe will call
   > serde/src/java/org/apache/hadoop/hive/serde2/thrift/TBinarySortableProtocol.java:418:    // slight hack to communicate to DynamicSerDe that the field ids are not
   > serde/src/java/org/apache/hadoop/hive/serde2/thrift/TCTLSeparatedProtocol.java:667:    // slight hack to communicate to DynamicSerDe that the field ids are not
   > ```
   
   I am under the impression that TCTLSeparatedProtocol is also not only used by DynamicSerDe (maybe TBinarySortableProtocol and ConfigurableTProtocol as well? ).
   Regarding the DynamicSerDe comments I would either try to track why they are there (or if the functionality is needed at all) -- or completely remove them to avoid confusion. Backup option would be to note DynamicSerDe is now not supported (as you did above)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org