You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/15 03:21:56 UTC

[GitHub] [shardingsphere] tristaZero commented on pull request #6340: make subquery in SubqueryRouteTest work well

tristaZero commented on pull request #6340:
URL: https://github.com/apache/shardingsphere/pull/6340#issuecomment-658522574


   Hi @strongduanmu  Thanks for your continued efforts!
   To make `SelectStatementContext` simple and clean, `xxxUtil` in a new `util` package is expected to consider. 
   What do you think?
   
   Besides, I also think  #6319  also needs a `xxxUtil`  to extract `all tables` from `SelectStatementContext`. Still, I am not sure it is a practical idea or not. So I'd glad to listen to your thought.  @jingshanglu  @strongduanmu 
   
   Thanks,
   Trista


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org